Make SliceHeader fields pub? about h264-reader HOT 5 CLOSED

Sorry for the delay - here's 0.7.0.

from h264-reader.

The only reason they are private is that I wrote a bunch of parsing code but hadn't worked out what the public API of the type should be yet. I haven't actually used the slice header data myself yet.

If you want access to specific fields, then I'd be happy to accept a patch that adds pub to the pieces you are after. If utility methods might be preferable instead of direct field access I'd be happy to look at that too.

from h264-reader.

Ok, makes sense. I will throw up a PR in a bit with the pieces that are needed for POC parsing.

from h264-reader.

I made a PR for making the fields needed pub here:
#41

Also made a second PR that is maybe more of an opinion piece.
#42
Curious what you think about it, mainly my reasoning about the FieldsAbsolut is that the field bottom_delta is a combination of the delta from the NAL and the pic_order_cnt_lsb which caused me a bit of confusion originally as it is no longer really a delta?

from h264-reader.

Thanks for merging the PRs! Are you planning to make a new release including those as well?

from h264-reader.