Unable to generate style names when compiled under `:simple` optimizations about spade HOT 5 CLOSED

Oooh okay. I was looking at the pre-optimization files, I guess.

So what's happening is under :simple optimization, the style factory functions are declared as, eg:

yacwat_simple.styles.global_class_factory$=function(a,b){ /* ... etc */}

Under :none optimizations (dev mode), it looks like:

yacwat_simple.styles.global_class_factory$ = (function yacwat_simple$styles$global_class_factory$(style_name20047,params20048){
/* ... etc */
})

and in :advanced optimization, it's simply eg:

function p_(a,b){ /* ... etc. */ }

As background, to avoid having to embed a string with the style name (and consequently unnecessarily inflating the JS file in :advanced compilation mode) I'm using the name of the function that generates the style to uniquely identify the style across the app. This makes sense because in :none mode the name of the function is the fully-qualified clojure name, and in advanced it's a globally unique short name, so in development you can also easily see which element comes from which function.

Since I'm assuming that closure will generate a function with a name, the way :simple optimizations generates the function declaration javascript breaks everything. Hmm....

from spade.

Hey so I just published version 1.0.4 which I believe fixes the issue. Please let me know how it works for you!

from spade.

Huzzah! It works! Thanks for the speedy response and fix!

As an aside, I've been using this library successfully since its public debut, and it has been a joy to switch over to from css-modules and herb. Love the simplicity and flexibility it provides, and I've been a heavy advocate for it when the occasions arise in r/Clojure and at the workplace! Just commending you on your work :)

from spade.

Your welcome! Glad to hear it's working :)

Thanks so much! That means a lot. I started this because I was also a bit frustrated with the existing solutions, so I'm happy to see that others are enjoying it as much as I am :)

from spade.

Thanks for the report! This is indeed odd, and it's definitely not intended that we don't work under :simple optimization. I guess I've only tested in dev and :advanced modes, so I've never seen this before. In fact, it looks like none of the styling works correctly under :simple optimization.

Looking at your sample project, it seems like the factory functions don't have a .name property when compiled under :simple optimizations. It's unclear why, though; the code generated in dev and :simple mode seems to be the same. But this is the cause—we use the name of the style function to generate the style ID to know which element to update in the DOM when/if the style changes....

from spade.