Git Product home page Git Product logo

Comments (2)

dhg avatar dhg commented on September 24, 2024

Hey,

Great stuff. I definitely jumped in and made the edits on the line-height pieces and the font-weight redundancies. I will be pushing out those edits later today.

As for the HelveticaNeue font stack...I think it looks alright in Windows, but if you get your hands a Windows machine and have an example of the gross rendering, let me know - I'd love to see it.

I'm pulling in your active state for the buttons - I agree...active states are awesome.

Finally, as for the 'micro-clearfix' - since the grid is so key to Skeleton, I am going to use it on my local build and when I do my next large round of testing, I will get a chance to make sure it works across all platforms and devices. If it does...it's totally in.

Thanks so much for the contribution and look forward to a micro-release later today with those fixes.

Cheers

from skeleton.

dhg avatar dhg commented on September 24, 2024

Going to close this issue and make one explicitly for the suggestion of micro-clearfix

from skeleton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.