Git Product home page Git Product logo

Comments (5)

craigrodway avatar craigrodway commented on September 24, 2024

I think this is the source of the issue you describe: https://github.com/dhgamache/Skeleton/blob/master/stylesheets/skeleton.css#L205

from skeleton.

dhg avatar dhg commented on September 24, 2024

Hi Craig,

Yeah, the clearfix is what makes the bottom of the .container clear, but it is not "adding" the 20px (it is making sure the parent is the same height as all its children). I know it's not the direct cause because it is effectively used elsewhere (960.gs) without the same result. This is one step closer though - I'll keep fiddling with it!

Thanks for your contribution and let me know if you manage to surface anything else!

Cheers
Dave

from skeleton.

craigrodway avatar craigrodway commented on September 24, 2024

Hi Dave

You're right, 960 does have that (I hadn't noticed before). However, it uses a space rather than a period character; and changing that in skeleton.css appears to remove the bottom margin (at least on the one design I'm working on at the moment).

from skeleton.

dhg avatar dhg commented on September 24, 2024

GOOD MAN! I actually had the .clearfix class with the correct space character, but somehow managed to put a period into the version for clearing the container. Thanks for the great catch! It has been updated in the source code :)

from skeleton.

craigrodway avatar craigrodway commented on September 24, 2024

Awesome. :)

from skeleton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.