Having more callbacks for error handling / change of state (disconnect -> connected) about easywsclient HOT 8 CLOSED

Great, I'll see what I can do ... I hope I'll have time to take the time to do it ... :)

BTW thanks so much for writing this library in the first place, it has helped us tremendously.

from easywsclient.

Here's the web browser api:

I don't think that we need the onmessage callback, but maybe we could use the other 3 ones, onerror, onclose, and onerror. There's another C++ library that has similar callbacks, actually a lot more. Maybe we don't need that many but those 3 I'm describing sounds like a good start -> https://github.com/zaphoyd/websocketpp/blob/master/websocketpp/connection.hpp

from easywsclient.

Read the web document a little further, and onclose is actually the only event that will carry a description of the "error". The other events do not carry any extra information.

from easywsclient.

@bsergean good idea
do you implement those callback onopen onerror onclose onmessage ...

from easywsclient.

Yeah I implemented those callbacks in my now heavily modified version of this (great) library. I should find a way to contribute it to this project or make a sister standalone project.

I also have SSL support on iOS and Android, macOS and Linux (didn't do anything on Windows though). What I did is make an abstraction for the socket transport. I reused a lot of SSL code from the satori C sdk, which is a C library that builds on top of web socket to give a pubsub with advanced features (such as SQL like queries) -> https://github.com/satori-com/satori-rtm-sdk-c/tree/master/core/src

from easywsclient.

Hi! I do support sending a pull request, with the following properties:

• Doesn't break backwards compatibility.
• Follows the style of the current code.
• Includes some integration tests in the test/ folder.

Making an abstraction for the socket transport sounds like the right way to go for SSL. I could look at the code, if you have a link handy, and give pre-pull-request feedback if you'd like.

Thanks for looking into this issue.

from easywsclient.

We finally open-sourced our library, here it is:

https://github.com/machinezone/IXWebSocket

from easywsclient.

Hey I won't need this that much now that we have our hacked-up version of easywsclient (btw I just added Windows support for it by again looking at easywsclient).

Closing to have less noise on the bug tracker.

from easywsclient.