Comments (2)
@bob-nl, I wish you luck. Other contributors regularly improve the code without regressing its features in the process. If you did the same, I would gladly accept your patch. In #35, I communicated the most important reasons for the code rejection, of which there were many reasons. If anyone else contributed such code, the outcome would be the same, regardless. I'm sorry you got offended, but frankly, if I were to accept your patch, it would be an offense to everyone else.
from easywsclient.
I request once already that you address the points on what exactly your patch is improving. You keep mentioning: clean, tested, and predictable. People who contribute the other patches do make sure the code is tested, and I myself test their patches. How is your code more clean and more predictable and more tested?
from easywsclient.
Related Issues (20)
- getting error when im trying to connect HOT 2
- about vector variable need be clear() and swap()
- not compiled on msys2 HOT 2
- "hostname_connect" funtion code bug
- Memory leak
- from_url() missing close(sockfd)
- Compiling
- connecting to wss through proxy
- How to add parameter at function handle_message
- hello,is there a bug here? HOT 1
- Update npm dependencies to resolve (harmless) security vulnerability in ws
- Check for invalid frame length HOT 1
- VS ERROR LNK2001 Unresolved external symbol easywsclient::WebSocket::from_url HOT 1
- Integrating with OSS-Fuzz HOT 5
- unable to connect: aborted
- Multiple Clients
- >65000 byte send fail
- Half closed connection not handled HOT 1
- Assertion 'ws' failed in ubuntu18.04 HOT 1
- Notifications from the server are not received HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easywsclient.