Git Product home page Git Product logo

Comments (2)

dhbaird avatar dhbaird commented on August 10, 2024

@bob-nl, I wish you luck. Other contributors regularly improve the code without regressing its features in the process. If you did the same, I would gladly accept your patch. In #35, I communicated the most important reasons for the code rejection, of which there were many reasons. If anyone else contributed such code, the outcome would be the same, regardless. I'm sorry you got offended, but frankly, if I were to accept your patch, it would be an offense to everyone else.

from easywsclient.

dhbaird avatar dhbaird commented on August 10, 2024

I request once already that you address the points on what exactly your patch is improving. You keep mentioning: clean, tested, and predictable. People who contribute the other patches do make sure the code is tested, and I myself test their patches. How is your code more clean and more predictable and more tested?

from easywsclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.