hope to support inheritance about keyedcodable HOT 4 CLOSED

dgrzeszczak commented on August 17, 2024

hope to support inheritance

from keyedcodable.

Comments (4)

faimin commented on August 17, 2024 1

@dgrzeszczak amazing, It fulfills my needs, thanks.

from keyedcodable.

dgrzeszczak commented on August 17, 2024

Hey, do you have any issue I can replicate ?

from keyedcodable.

faimin commented on August 17, 2024

yes, keyedCoable seem to don't support inheritance of class

demo code

class SuperClass {
    var name: String?
    var sex: String?
    var age: Int?
}

class SubClass: SuperClass, Codable {
    var a: String?
    var b: Int?
    
    enum CodingKeys: String, KeyedKey {
        case a, b
    }
}

private let jsonString = """
{
    "name": "John",
    "age": 18,
    "sex": "F",
    "a": "aa",
    "b": 100,
    "qqqq": {
        ".greeting": "Hallo world",
        "details": {
            "description": "Its nice here"
        }
    },
    "longitude": 3.2,
    "latitude": 3.4
}
"""

func testCodable() throws {
        let jsonData = jsonString.data(using: .utf8)!
        
        let model = try SubClass.keyed.fromJSON(jsonData)
        
        print(model) 
}

result

(CodableTests.SubClass) model = 0x00006000003a4180 {
  CodableTests.SuperClass = {
    name = nil
    sex = nil
    age = nil
  }
  a = "aa"
  b = 100
}

from keyedcodable.

dgrzeszczak commented on August 17, 2024

Thank you for detailed description. I'll look on that but it may be hard to support - it's known issue of Codables and it's not related with KeyedCodables.

What do you think to use composition instead of inheritance? Using @Flat you will use the same JSON format. Your example will look like that.

class SuperClass: Codable {
    var name: String?
    var sex: String?
    var age: Int?
}

class SubClass: Codable {
    var a: String?
    var b: Int?

    @Flat var c: SuperClass // may be optional as well @Flat var c: SuperClass?
}

from keyedcodable.

Recommend Projects