Comments (4)
Hey Chris,
thank you for the commit. To be honest I am not a big fun of adding custom facts, if they are not really necessary.
In a big puppet installation more custom facts you have, more time it takes the puppet agent to start/finish. Hopefully cfacter will fix that, but is still few months away.
Usually if I really need some custom facts I add them per environment in the common module. Also if I install gpg keys on a node, I know that I need them there, and if so I include the gnupg class.
What are your thoughts on that ?
from golja-gnupg.
RVM uses the which command to determine if gpg is installed. If it is, it looks for a gpg key and fails if one is not present.
https://github.com/wayneeseguin/rvm/blob/480fbc35211940dc2d5ac09ce630e1a161090f70/binscripts/rvm-installer#L386
We are simply trying to replicate this in the RVM module and only add a key if needed to avoid failure.
The RVM module should not install gnupg if it is not present. That is what this module is for.
So we need to determine if in fact gpg is present. We are currently using this exec, which I find sloppy.
https://github.com/maestrodev/puppet-rvm/blob/master/manifests/system.pp#L38
I think this is a good use of a fact and I would much rather use this modules gnupg_key
type.
I suppose we could add the fact to the RVM module, but I feel it makes more sense for it to go in this module, as it is more related to gpg.
More info here:
voxpupuli/puppet-rvm#86
from golja-gnupg.
HaHa I like your obsession to make the code less sloppy
I guess if https://github.com/carlossg want to make his module depending on mine we can add this new feature.
from golja-gnupg.
done ... sorry for the delay and thank you again for the PR.
from golja-gnupg.
Related Issues (15)
- undefined method `exitstatus' HOT 5
- Setting Trust Level of Installed Keys HOT 3
- Applying gnupg_key fails if an Agent-side directory environment is missing HOT 4
- Remove PaxHeaders from distributed package HOT 11
- add support for fetching the gpgkey through a http proxy.
- 1.2.3 tag missing HOT 2
- key type parameter uses unquoted string in ready which leads to reserved word errors HOT 3
- Support for puppet v4 HOT 1
- Key is recreated with every puppet run
- Renewing Puppet Forge Approved Status HOT 7
- Declaration of package { 'gnupg': } in the manifest install.pp conflicts with module puppetlabs-apt HOT 2
- URI.escape is deprected in Ruby 3.0
- Allow usernames with dashes HOT 1
- gnupg's user should be autorequired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from golja-gnupg.