Check canister id in `post_upgrade` about internet-identity HOT 4 CLOSED

I think the simplest solution would be to add /canister_id here (which replies with api::id) and replace canisterId with a singleton (not the haskell kind, this kind) that fetches from /canister_id. WDYT?

from internet-identity.

Not sure I follow. Are you describing how to not hardcode the canister id in the frontend?

from internet-identity.

My bad, yes of course! Is there any other reason why we'd check the canister ID?

from internet-identity.

The reason to check the canister id in post_upgrade is to fail at the last moment if an mistake in a canister upgrade proposal would otherwise override, say, the ledger.

But actually since @roman-kashitsyn 's stable memory format includes a magic string that is being checked, that should be sufficient, so I'll close this.

from internet-identity.