Git Product home page Git Product logo

Comments (5)

erikbgithub avatar erikbgithub commented on June 30, 2024

changes still work in progress. putting it all together and rebasing it to the current dev branch somehow introduced some new errors and warnings.

from monk.

erikbgithub avatar erikbgithub commented on June 30, 2024

For reviewers: After you finished reading the commit itself and feel there is everything okay, please check that the results also work for you. The following code snippets should guide you through the active part of the review

$ cd <monk_folder>
$ git pull --rebase
$ git checkout f-recreate-docs
$ cd doc
$ make html
# a) see that there should only be warnings about uuid_.py which will be removed with https://github.com/DFE/MONK/issues/38
# b) also check the html files locally, if they are generated correctly, if there are pictures and logo inside and if links inside work (e.g. to the MONK modules)
$ make latexpdf
# a) see that there are no warnings/errors before(!) latexpdf starts it's work
# b) have a look if there will be a resulting pdf with meaningful (although maybe ugly) content

from monk.

toang avatar toang commented on June 30, 2024

Everything looks fine to me -> ACK.

from monk.

sledz avatar sledz commented on June 30, 2024

Is it really a good idea make the targets html and latexpdf depend on clean?

Making one of the targets removes the artifacts of the other one. :(

from monk.

sledz avatar sledz commented on June 30, 2024

ACK

from monk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.