Comments (5)
changes still work in progress. putting it all together and rebasing it to the current dev
branch somehow introduced some new errors and warnings.
from monk.
For reviewers: After you finished reading the commit itself and feel there is everything okay, please check that the results also work for you. The following code snippets should guide you through the active part of the review
$ cd <monk_folder>
$ git pull --rebase
$ git checkout f-recreate-docs
$ cd doc
$ make html
# a) see that there should only be warnings about uuid_.py which will be removed with https://github.com/DFE/MONK/issues/38
# b) also check the html files locally, if they are generated correctly, if there are pictures and logo inside and if links inside work (e.g. to the MONK modules)
$ make latexpdf
# a) see that there are no warnings/errors before(!) latexpdf starts it's work
# b) have a look if there will be a resulting pdf with meaningful (although maybe ugly) content
from monk.
Everything looks fine to me -> ACK.
from monk.
Is it really a good idea make the targets html
and latexpdf
depend on clean
?
Making one of the targets removes the artifacts of the other one. :(
from monk.
ACK
from monk.
Related Issues (20)
- SerialConnection: When connect() to shutdown device still 'Connected' HOT 1
- Connected.login(): should not switch state when login fails HOT 1
- Serial Login: Expected Logging+Behaviour HOT 1
- Conn.name&Dev.name: renaming for logger should be possible afterwards
- AConnection.can_login(): Should only check for login prompt
- AConnectionException not ConnectionException
- Prepare release 0.1.6
- When logging out still Authenticated? HOT 1
- Terminal Control Sequences in Output HOT 6
- clean up unit test suite HOT 1
- Fixture.tear_down() might not be reached
- Test Connections should be usable from fixture files
- Fixture Exception should not be called DeviceException
- Fixture should have a `cmd()`
- Add Debug Message for Fixture's props type after reading a fixture file
- XiniParser doesn't raise error on non-existing fixture files
- conn.Authenticated.login() executed LOGGED_OUT
- Prepare release 0.1.5
- Serial's _cmd uses wrong string
- Connection doesn't login correclty
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monk.