Git Product home page Git Product logo

Comments (5)

connorshea avatar connorshea commented on July 20, 2024 1

Apologies for being a nuisance, but I figure someone has to be :P

I'll be testing the devise-4 branch with GitLab (along with Devise 4/attr_encrypted 3.0) in the next few days. Assuming nothing breaks horribly, it should be good to merge.

Rails 5.0.0.rc1 came out today, so I figured it was important to get this shipped: https://github.com/rails/rails/releases/tag/v5.0.0.rc1

If there's anything else I can do to get this moving along, I'd be happy to help.

from devise-two-factor.

connorshea avatar connorshea commented on July 20, 2024

Maybe also allow rotp 3.0 in the gemspec?

Here's the breaking change introduced in that version.

from devise-two-factor.

connorshea avatar connorshea commented on July 20, 2024

pokes @bsedat 😛

from devise-two-factor.

connorshea avatar connorshea commented on July 20, 2024

Alternatively @ShaneWilton, I'd like to upgrade to Devise 4 if possible :)

from devise-two-factor.

connorshea avatar connorshea commented on July 20, 2024

Other than #91 (and merging #90), devise-two-factor (with devise-4 merged into master) seems to be working fine based on my tests with GitLab :)

from devise-two-factor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.