Git Product home page Git Product logo

Comments (4)

monfresh avatar monfresh commented on July 20, 2024 3

The ROTP gem has now implemented this via the verify_with_drift_and_prior method. See: https://github.com/mdp/rotp#preventing-reuse-of-time-based-otps

Would it make sense for this gem to use that functionality as opposed to your own implementation?

from devise-two-factor.

monfresh avatar monfresh commented on July 20, 2024

I updated my comment. I had pasted in the wrong code initially.

If you play around with the amount_to_travel value, you'll see that when the amount of time to travel is equal to the drift period or between the drift period and twice the drift period, the test fails, but if you advance 60 seconds, then the test passes.

from devise-two-factor.

monfresh avatar monfresh commented on July 20, 2024

Here is an interesting discussion on this subject: mdp/rotp#44

from devise-two-factor.

QuinnWilton avatar QuinnWilton commented on July 20, 2024

I think that'd be a worthwhile change to make. Thanks for pointing it out!

If you were to open a pull request, I'd be happy to review it.

from devise-two-factor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.