Comments (4)
The ROTP gem has now implemented this via the verify_with_drift_and_prior
method. See: https://github.com/mdp/rotp#preventing-reuse-of-time-based-otps
Would it make sense for this gem to use that functionality as opposed to your own implementation?
from devise-two-factor.
I updated my comment. I had pasted in the wrong code initially.
If you play around with the amount_to_travel
value, you'll see that when the amount of time to travel is equal to the drift period or between the drift period and twice the drift period, the test fails, but if you advance 60 seconds, then the test passes.
from devise-two-factor.
Here is an interesting discussion on this subject: mdp/rotp#44
from devise-two-factor.
I think that'd be a worthwhile change to make. Thanks for pointing it out!
If you were to open a pull request, I'd be happy to review it.
from devise-two-factor.
Related Issues (20)
- Duplicate Warden strategy :two_factor_authenticatable HOT 1
- Help resolving CVE for inner dependency HOT 3
- Clarification about setup with rails 6 HOT 1
- missing attribute: encrypted_otp_secret
- Remove "Rails 4" misleading sentences from readme
- NoMethodError Exception: undefined method `tr' for nil:NilClass HOT 1
- Require email verification when enabling Authenticator App type
- Generator throws exception HOT 1
- `Devise.add_module(:two_factor_authenticatable)` should be inserted on top
- calling super in the two factor strategy is problematic...
- Remove the old `otp_secret_encryption_key` in the UPGRADING.md guide
- Git tag for v4.1.0 appears to be missing HOT 2
- No changelog for 4.1.0
- `user.current_otp` code sent to user are always invalid HOT 1
- [question] mass users update?
- Not required on every login HOT 1
- Rails 7.1 on 4.x HOT 1
- Support for Rails 7.1 HOT 3
- ActiveRecord::Encryption::Errors::Decryption error on login after upgrade to Rails 7.1 defaults HOT 3
- Backup codes aren't written to the database so can't be used HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise-two-factor.