Comments (6)
cc: @bsedat, don't mean to be intrusive or anything, just figured this was important.
from devise-two-factor.
Good finds! No need for the extra CC, I get notified for repo activity automatically 😄
I don't have any bandwidth at the moment to fix this, but happy to look at any pull requests. We'll need to bump the minimum ruby version to be 2.0.0+ in order to have access to Module#prepend
from devise-two-factor.
Ah, wasn't sure :) I'll see about opening a PR to make the gem compatible with Devise 4.0, but I'm not much of a Ruby expert so I probably won't be able to fix the deprecation warnings.
from devise-two-factor.
Looks like this is a problem in attr_encrypted that was just fixed in 2.0.0. I'll test devise-two-factor with the 2.0.0 version of the gem.
from devise-two-factor.
It wasn't fixed in 2.0.0, I was mistaken. I've opened an issue in the repository to get the deprecation warnings fixed. We should keep this issue open to update the gem to 2.x when it's fixed.
from devise-two-factor.
I think we can close this, since it's not an issue with devise-two-factor itself.
from devise-two-factor.
Related Issues (20)
- Help resolving CVE for inner dependency HOT 3
- Clarification about setup with rails 6 HOT 1
- missing attribute: encrypted_otp_secret
- Remove "Rails 4" misleading sentences from readme
- NoMethodError Exception: undefined method `tr' for nil:NilClass HOT 1
- Require email verification when enabling Authenticator App type
- Generator throws exception HOT 1
- `Devise.add_module(:two_factor_authenticatable)` should be inserted on top
- calling super in the two factor strategy is problematic...
- Remove the old `otp_secret_encryption_key` in the UPGRADING.md guide
- Git tag for v4.1.0 appears to be missing HOT 2
- No changelog for 4.1.0
- `user.current_otp` code sent to user are always invalid HOT 1
- [question] mass users update?
- Not required on every login HOT 1
- Rails 7.1 on 4.x HOT 1
- Support for Rails 7.1 HOT 3
- ActiveRecord::Encryption::Errors::Decryption error on login after upgrade to Rails 7.1 defaults HOT 3
- Backup codes aren't written to the database so can't be used HOT 1
- Clarification on GHSA-chcr-x7hc-8fp8 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise-two-factor.