Git Product home page Git Product logo

Comments (6)

connorshea avatar connorshea commented on July 2, 2024

cc: @bsedat, don't mean to be intrusive or anything, just figured this was important.

from devise-two-factor.

bsedat avatar bsedat commented on July 2, 2024

Good finds! No need for the extra CC, I get notified for repo activity automatically 😄

I don't have any bandwidth at the moment to fix this, but happy to look at any pull requests. We'll need to bump the minimum ruby version to be 2.0.0+ in order to have access to Module#prepend

from devise-two-factor.

connorshea avatar connorshea commented on July 2, 2024

Ah, wasn't sure :) I'll see about opening a PR to make the gem compatible with Devise 4.0, but I'm not much of a Ruby expert so I probably won't be able to fix the deprecation warnings.

from devise-two-factor.

connorshea avatar connorshea commented on July 2, 2024

Looks like this is a problem in attr_encrypted that was just fixed in 2.0.0. I'll test devise-two-factor with the 2.0.0 version of the gem.

from devise-two-factor.

connorshea avatar connorshea commented on July 2, 2024

It wasn't fixed in 2.0.0, I was mistaken. I've opened an issue in the repository to get the deprecation warnings fixed. We should keep this issue open to update the gem to 2.x when it's fixed.

from devise-two-factor.

connorshea avatar connorshea commented on July 2, 2024

I think we can close this, since it's not an issue with devise-two-factor itself.

from devise-two-factor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.