Git Product home page Git Product logo

Comments (7)

samruddhikhandale avatar samruddhikhandale commented on May 19, 2024 1

When these templates were in the old repo, they shared same docs with images. For having node handy, all the images have a reason similar to this this one 👇

Given JavaScript front-end web client code written for use in conjunction with a Python back-end often requires the use of Node.js-based utilities to build, this container also includes nvm so that you can easily install Node.js.

Looks like it was assumed that node is helpful with most of the platforms/runtimes. This is what I think from the docs & why I kept this option during migration.

@Chuxel / @bamurtaugh might know the real reason behind it.

from templates.

samruddhikhandale avatar samruddhikhandale commented on May 19, 2024 1

There are few other templates which provides Node options in the UX. I'll remove those from Templates 👍

from templates.

Chuxel avatar Chuxel commented on May 19, 2024

Is there a problem we're trying to resolve here? e.g., has someone complained (I might have missed it)?

To break it down:

  1. Most use cases for the images at the time were to enable web and service development where node was used by tools to generate client-side content (e.g. via webpack) even if you weren't deploying that way. Having yarn and nvm there by default both enabled these common tools use cases.
  2. Image build performance is always a focus and removing the need to install yarn and nvm helps here.
  3. Features didn't exist at the time.

Certainly, we could remove it from the template while still building yarn and nvm into the base image. Might that be a good way to get the best of all worlds?

from templates.

chrmarti avatar chrmarti commented on May 19, 2024

We recently added a lightweight way to create a dev container from scratch without a local folder or repository and there the additional and somewhat redundant step stood out and was brought to my attention. The UI steps are:

  • Pick the Python template.
  • Decide if and which Node version you want.
  • Pick any additional features (including Node).

Since Node (and many other potentially useful tools) are offered as features, it seems we can remove Node from the template options. Having Node as an option made sense before we had features. I haven't checked which of the other templates are doing the same, but we could look into simplifying these too.

from templates.

Chuxel avatar Chuxel commented on May 19, 2024

Yeah I think we can remove it from the template - but we can still leave it in the image is my PoV. Retains the original functionality that way.

from templates.

bamurtaugh avatar bamurtaugh commented on May 19, 2024

+1 to removing - I think removing it would set the right precedent for other templates, where we want users to build up with features as much as possible.

from templates.

samruddhikhandale avatar samruddhikhandale commented on May 19, 2024

Closing as fixed with #59 🚀

from templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.