Comments (7)
Thanks for bringing this up! I was able to recreate the issue locally; not sure when this broke but I’ll have a patch out ASAP.
from thebananostand.
Hey @gbl08ma do you have multiple accounts already pre-loaded on your dashboard when you open the wallet? I thought I was able to recreate the issue but I only had 1 account loaded in the wallet. Here's a gif of what I'm seeing:
from thebananostand.
Secondary wallet (multiple seeds), not account. Previously the dropdown would show me the addresses of all seeds and now it only shows the addresses of the first wallet I have configured. If I close the popup, I can switch to the other wallets fine, so it's not a problem unlocking those wallets.
from thebananostand.
Secondary wallet (multiple seeds), not account. Previously the dropdown would show me the addresses of all seeds and now it only shows the addresses of the first wallet I have configured. If I close the popup, I can switch to the other wallets fine, so it's not a problem unlocking those wallets.
Hey sorry for the delay on this; revisiting the issue I believe this is how the app always behaved.
Whenever someone with multiple wallets loads the app, only the active wallet (most-recently selected one, set in local storage) & accounts are loaded. I'm not storing any public addresses in local storage, just the indexes of each account per wallet so on load, the dialog only has access to the active wallet's account list as it's fetched.
There's a work-around for this but isn't user-friendly (close dialog, select wallet, refresh the page). I've got two ideas in mind for how to patch this:
-- Change the send/receive/change request via params prompt from a dialog on-load to an action banner. That way, a user can load the app like normal & click the prompt themselves to start the requested action workflow once they've chosen which wallet is active.
-- Add an additional step in the dialog workflow to select wallet, keep the rest of the workflow the same.
I'm leaning forwards the first option since I've never liked how the app is still loading in the background when the dialog opens.
from thebananostand.
I am absolutely certain that I was able to send from an account on the third wallet I have configured, when opening with ?request=send, and I did that possibly dozens of times without fail. Then one day it stopped working, but it's possible I did not pay attention to the fact I had last selected a different wallet on another tab. I can confirm that if I take care to select the right wallet on one tab before opening the new tab with ?request=send, I can send from the wallet I want. Still, I think it would make sense to allow selecting the wallet to send from within the ?request=send session. I think the simplest way to do that without changing the current flow too much, would be to add a "Use a different wallet" option on this screen (or to outright have two dropdowns there, one for the wallet and another for the account, with the one for the wallet only appearing if the user has multiple wallets configured, to keep things simpler for other users):
from thebananostand.
Sounds like the multiple tabs was what was causing this to happen 👀
To provide the quickest fix I'll just add a wallet select in the flow so it'll look like this:
from thebananostand.
This is added in #121 & should be deployed shortly 👍
from thebananostand.
Related Issues (20)
- Feature: Accompany every Banano address displayed with a monKey HOT 1
- Feature: Dropdown to select recipients from address book when sending
- Feature: Push notifications so the user doesn't have to manually reload pages.
- Deal with newlines in messages to sign HOT 2
- Feature: Alias & Address Book enhancements
- Feature: Make receivable items more intuitive
- Add Option to add own RPC node HOT 1
- Respect external API rate limits
- is this new official wallet? HOT 1
- Can paste the letter "e" in send value and it treats as exponent.
- New wallet link has poor contrast under festive conditions
- Send links without amount don't work properly HOT 1
- Add Wallet Option to Receive All
- Add minimum receivable threshold
- Fix Dashboard Sortation
- Set up Analytics HOT 1
- Host app in Electron
- Timeout unlocked wallet
- Feature: Bluetooth Ledger Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thebananostand.