Git Product home page Git Product logo

Comments (12)

tijno avatar tijno commented on August 14, 2024

i think the only option is to either allow a the generic google bucket domain on all nodes, or allow any domain for image embeds on all nodes (eg disabled csp for images)

from core.

marnimelrose avatar marnimelrose commented on August 14, 2024

So if you watch this quick video, you will notice that if you set up with no credentials and just use images.bitclout.com that the images will post fine on your node and all others
https://www.loom.com/share/46b85cfddb934d2ba72e1b06279789c5
BTW - I just hid that post, I just wanted you to see it for yourself in the video.

from core.

maebeam avatar maebeam commented on August 14, 2024

@MirekR I would recommend using the bitclout.com upload-image endpoint.

from core.

MirekR avatar MirekR commented on August 14, 2024

@maebeam I guess we can use it but what is the point allowing to change the bucket then?

@marnimelrose thanks for the video but not sure it that’s 100% correct. The node front end seems to be using the bitclout.com uplod-image endpoint (as maebeam suggested to use as well) regardless of the settings. Issue arise when you try to call the upload-image endpoint (from mobile app for example). If you set it up as you suggest, it fails the upload.

from core.

tijno avatar tijno commented on August 14, 2024

@maebeam ive seen reports that using the default bitclout one does not work from non bitclout.com nodes - but have not tested this myself.

will test today

from core.

maebeam avatar maebeam commented on August 14, 2024

@tijno Let me know if you get CORS. I am happy to turn off CORS for that endpoint.

from core.

tijno avatar tijno commented on August 14, 2024

Looks like it maybe @maebeam - although this could relate to my CSP on frontend but I do have bitclout.com:* in my connect-src so it should be able to make requests to https://bitclout.com/api/v0/upload-image

20210718-4qQA27OO

from core.

maebeam avatar maebeam commented on August 14, 2024

That looks like a CSP error to me

from core.

MirekR avatar MirekR commented on August 14, 2024

@tijno you might want to change image-src, not connect-src to make it work?

from core.

tijno avatar tijno commented on August 14, 2024

its the api upload req to bitclout.com that fails - cant get csp update in Caddyfile to stick somehow so still waiting to rule out csp issue on my end

from core.

tijno avatar tijno commented on August 14, 2024

The issue on my end was that bitclout.com was no longer in my Caddyfile CSP section and cloudflare caching was delaying any changes from showing up.

20210722-t30Okuul

@MirekR All working correctly now and I was able to post images from my node using the default empty GCP_BUCKET in the dev.env file so it uses images.bitclout.com

from core.

maebeam avatar maebeam commented on August 14, 2024

I'm going to close this since it appears everything is working as intended.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.