Git Product home page Git Product logo

Comments (5)

derf avatar derf commented on July 19, 2024

Looks like the limit is caused by hardware-dependent maximums, at least none of your images work on my 32bit machine. I can't even convert(1) them to a smaller version without invoking the OOM killer. :>

Anyways, I'm not sure if this issue should be addressed to feh or Imlib2, but I'll investigate it some more some time. Thanks for reporting!

from feh.

livibetter avatar livibetter commented on July 19, 2024

I tracked down why it fails at least for the bigger one, because Imlib2 (1.4.4) has image size limitation.

in load() of loader_jpeg.c

    if (!IMAGE_DIMENSIONS_OK(w, h))

and in image.h

# define IMAGE_DIMENSIONS_OK(w, h) \
   ( ((w) > 0) && ((h) > 0) && \
     ((unsigned long long)(w) * (unsigned long long)(h) <= (1ULL << 29) - 1) )

#endif

and

>>> (1 << 29) - 1
536870911
>>> 23018 * 22995                                                                                                      
529298910
>>> 23325 * 23302                                                                                                      
543519150

I got IMLIB_LOAD_ERROR_UNKNOWN for BOTH files (on x86_64), if imlib2 had IMLIB_LOAD_ERROR_IMAGE_TOO_BIG, then I didn't need to get into the code. No idea why the smaller one fails.

from feh.

livibetter avatar livibetter commented on July 19, 2024

I know why the good one failed on my computer, it's because I don't have enough free memory. (why I didn't notice the number is 536,870,911?) I guess imlib2 will see if there is enough memory to use or it just allocates and see if it can gets memory. I only have 2GB, even I closed all programs I could, but it was still not enough. So I turn on swap, nearly 3GB was used and feh showed the image.

As stated in my previous comment, there is a limitation and there is nothing feh can do. Actually, feh has nothing to do with the loading failure.

I don't know if you can just lift that limit in imlib2 to get image loaded, anyway, this should be reported to imlib2 if you want this to be fixed.

from feh.

rcbarnes avatar rcbarnes commented on July 19, 2024

I actually get feh crashes with images 1920(w) by <8k(h). I don't know if this is related, but if not, I'm happy to open a new bug and provide some example images...

from feh.

dayne avatar dayne commented on July 19, 2024

Noticed this issue still open - looped back and tested against latest feh against the same images as before. Problem has been solved at some point. Used the system installed feh on an Ubuntu 16.04 system

Closing!

from feh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.