Comments (2)
mjtorn
commented on July 30, 2024
Or wait. Is that value_for_object and/or model_to_dict used in form validation? I might have misread the code;
the clean method tries also to call loads on the given value, so it might actually fail it if it's given a real data structure.
Wouldn't the first dumps then always be ok?
It might be best not to introduce the change, and I could make another pull request with only the contribute_to_class, although I would have to hack around at my code (a preferrable choice to either maintaining a fork or using something less established than your project)
Comments?
from django-json-field.
mjtorn
commented on July 30, 2024
Yeah, let's close this, the form gets too fishy otherwise.
from django-json-field.
Related Issues (20)
- Simple use of the formfield throws a KeyError
- TypeError: db_type() got multiple values for keyword argument 'connection' HOT 3
- Decimal rounding HOT 2
- Decoding/encoding time/date/datetime should be optional, if not disabled by default. HOT 1
- JSONFormField should absolutely not be eval-ing user-supplied content. HOT 1
- Can't install from empty virtualenv HOT 1
- Incompatible with Django 1.5 due to change from simplejson to json HOT 5
- `JSONFormField.clean` should return a python object and not it's string representation. HOT 4
- test_decimal fails on django1.5 HOT 2
- Doesn't support Django 1.3 HOT 2
- A nicer error message could be displayed in the case of a wrong value in the admin. HOT 1
- go to build-in Python json instead of simplejson HOT 3
- Why decimal? HOT 6
- Wrong default value for South migration HOT 2
- TypeError: 'NoneType' object is not iterable - for string that begins with date, but not represent date HOT 4
- Django 1.7 compatibility HOT 8
- Django 1.9 compatibility HOT 1
- Json field validation?
- field default set to 'null' is breaking support form modelform's initial data
- installation in django
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-json-field.