Make a new LMI_HOLD function about omnipay-webmoney HOT 15 CLOSED

Please add this feature an do a PR

from omnipay-webmoney.

Sorry, but coudn't add this to PR or didn't understand how to do it (interface of Github showing that there is nothing to compare if i press to new PR).

from omnipay-webmoney.

Show me your code pls

from omnipay-webmoney.

I didn't have any code. I can translate to you the WebMoney wiki article for new function.

from omnipay-webmoney.

Currently i have no time to add this feature. So if you want it, you have to add it by your own

from omnipay-webmoney.

Now i did it by this code in PurchaseRequest.php:
return array(
'LMI_PAYEE_PURSE' => $this->getMerchantPurse(),
'LMI_PAYMENT_AMOUNT' => $this->getAmount(),
'LMI_PAYMENT_NO' => $this->getTransactionId(),
'LMI_PAYMENT_DESC_BASE64' => base64_encode($this->getDescription()),
'LMI_SIM_MODE' => $this->getTestMode() ? '2' : '0',
'LMI_RESULT_URL' => $this->getNotifyUrl(),
'LMI_SUCCESS_URL' => $this->getReturnUrl(),
'LMI_SUCCESS_METHOD' => $this->getReturnMethod(),
'LMI_FAIL_URL' => $this->getCancelUrl(),
'LMI_FAIL_METHOD' => $this->getCancelMethod(),
'LMI_HOLD' => '0',
LMI_HOLD is hold function due to WebMoney Merchant documentary, but i didn't know how to make a function of setting number of days in LMI_HOLD. I set it to deault value 'LMI_HOLD' => '0', so it would be 1 day as in example of WebMoney Merchant. Please check it.

from omnipay-webmoney.

So possible values for LMI_HOLD are 0 or 1. Default 0. Right?

from omnipay-webmoney.

Yes, default is 0 (24 hours). And LMI_HOLD value is number of days for holding money without commision on moneyback. So LMI_HOLD could be any number of days - deault is 0 (24 hour) and 1, 2 ,3 and so on.

from omnipay-webmoney.

I understand

from omnipay-webmoney.

LMI_HOLD meens that in value of this days (deafult 24 hours) money is holded. And if the merchant didn't accept transaction in those period of time (days) those money will be backed to purchaser without any commision from WebMoney.

from omnipay-webmoney.

I setup it as 24 hours in message/PurchaseRequest.php file by this code:
return array(
'LMI_PAYEE_PURSE' => $this->getMerchantPurse(),
'LMI_PAYMENT_AMOUNT' => $this->getAmount(),
'LMI_PAYMENT_NO' => $this->getTransactionId(),
'LMI_PAYMENT_DESC_BASE64' => base64_encode($this->getDescription()),
'LMI_SIM_MODE' => $this->getTestMode() ? '2' : '0',
'LMI_RESULT_URL' => $this->getNotifyUrl(),
'LMI_SUCCESS_URL' => $this->getReturnUrl(),
'LMI_SUCCESS_METHOD' => $this->getReturnMethod(),
'LMI_FAIL_URL' => $this->getCancelUrl(),
'LMI_FAIL_METHOD' => $this->getCancelMethod(),
'LMI_HOLD' => '0',

from omnipay-webmoney.

Please try my latest commit.
getHold() and setHold() functions have been added now

from omnipay-webmoney.

Ok. Will check. Thanks.

from omnipay-webmoney.

Does it work?

from omnipay-webmoney.

I think we can close this one

from omnipay-webmoney.