Git Product home page Git Product logo

Comments (17)

mkw avatar mkw commented on September 22, 2024 1

Works perfectly, including the x86 build on arm64:

mwerle@IT-USA-VX2065 ~(master)$ brew tap depscloud/tap
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 2 taps (homebrew/core and homebrew/cask).
==> Updated Formulae
Updated 3 formulae.
==> Updated Casks
Updated 2 casks.

mwerle@IT-USA-VX2065 ~(master)$ brew search deps
==> Formulae
depscloud/tap/depscloud-cli                                                                                             depscloud/tap/[email protected]
mwerle@IT-USA-VX2065 ~(master)$ brew install depscloud/tap/[email protected]
==> Installing [email protected] from depscloud/tap
==> Downloading https://github.com/depscloud/depscloud/releases/download/v0.2.34/deps_0.2.34_darwin_amd64.tar.gz
==> Downloading from https://github-releases.githubusercontent.com/289292765/87e18f80-7df8-11eb-9d40-eec17828b34e?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20210408%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=
######################################################################## 100.0%
🍺  /opt/homebrew/Cellar/[email protected]/0.2.34: 5 files, 13.2MB, built in 5 seconds
mwerle@IT-USA-VX2065 ~(master)$ deps version
deps {"version":"0.2.34","commit":"e85b382a817c61bb86ac3d3dbda6cd976991e7bd","date":"2021-03-06T03:13:58Z"}```

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

We're tracking this. It requires upgrading to Go 1.16 which was only just released recently. A .2 patch was released with a bunch of bug fixes. Once the linked PR is merged, this repo will be updated automatically.

from homebrew-tap.

arlaneenalra avatar arlaneenalra commented on September 22, 2024

Sorry, this is not just an M1 issue. I'm seeing it on an intel Mac as well:

csalch@IT-USA-25903 self_review % brew tap depscloud/tap
==> Tapping depscloud/tap
Cloning into '/usr/local/Homebrew/Library/Taps/depscloud/homebrew-tap'...
remote: Enumerating objects: 78, done.
remote: Counting objects: 100% (78/78), done.
remote: Compressing objects: 100% (75/75), done.
remote: Total 78 (delta 45), reused 8 (delta 3), pack-reused 0
Receiving objects: 100% (78/78), 17.79 KiB | 5.93 MiB/s, done.
Resolving deltas: 100% (45/45), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/depscloud/homebrew-tap/[email protected]
No available formula with the name "[email protected]".
In formula file: /usr/local/Homebrew/Library/Taps/depscloud/homebrew-tap/[email protected]
Expected to find class DepscloudCli@v02X, but only found: DepscloudCli.
Error: Cannot tap depscloud/tap: invalid syntax in tap!

from homebrew-tap.

arlaneenalra avatar arlaneenalra commented on September 22, 2024

Basically, new machines cannot tap the repository ..

from homebrew-tap.

arlaneenalra avatar arlaneenalra commented on September 22, 2024

It's likely related to the class name in https://github.com/depscloud/homebrew-tap/blob/main/depscloud-cli%40v0.2.x.rb#L6 ..

from homebrew-tap.

arlaneenalra avatar arlaneenalra commented on September 22, 2024

This may be two different bugs, at a minimum, the v0.2.x formula is invalid ...

Yeah, there are two issues here. Then new @v0.2.x formula is invalid and the old one does not have a url on M1 ... so it fails out ... That also means that the new one will fail out on M1 as well ..

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

I haven't merged the M1 support yet, but once the CLA is in, it should be pretty easy to land support for that.

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

@mkw and @arlaneenalra this is now available in 0.3.1.

from homebrew-tap.

mkw avatar mkw commented on September 22, 2024

Thanks!

from homebrew-tap.

mkw avatar mkw commented on September 22, 2024

Well, this is annoying: The current formula is fixed, but Brew is still detecting that there is no URL on macOS arm64 for the 0.2.x one, making it impossible to tap the repository on an Apple Silicon machine:

$ brew tap depscloud/tap
==> Tapping depscloud/tap
Cloning into '/opt/homebrew/Library/Taps/depscloud/homebrew-tap'...
warning: templates not found in /Users/mwerle/.git-templates
remote: Enumerating objects: 85, done.
remote: Counting objects: 100% (85/85), done.
remote: Compressing objects: 100% (81/81), done.
remote: Total 85 (delta 49), reused 11 (delta 4), pack-reused 0
Receiving objects: 100% (85/85), 19.22 KiB | 6.41 MiB/s, done.
Resolving deltas: 100% (49/49), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/depscloud/homebrew-tap/[email protected]
formulae require at least a URL
Error: Cannot tap depscloud/tap: invalid syntax in tap!

I am pretty sure that Rosetta would allow executing the x86 version, so you might just drop the Hardware::CPU.intel? on line 12 of that formula.

Do you want a new issue?

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

hmm... @mkw apple silicon is only available in v0.3.1. I don't have any intention of backporting it... this tap issue looks a lot like the issue @arlaneenalra resolved... I was able to verify it still worked by forcing homebrew to update the repo...

Can you try 0.3.1 and let me know if you still have this issue.

from homebrew-tap.

arlaneenalra avatar arlaneenalra commented on September 22, 2024

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

I don't think so. goreleaser updated the 0.3.0 file as expected and that included a line for darwin arm (link). This looks like it's complaining about the 0.2.x.rb file which is manually maintained at this point and does/will not support arm.

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

It is interesting that you can't tap something if a single formula doesn't have a supported URL...

from homebrew-tap.

mkw avatar mkw commented on September 22, 2024

Yea -- I really consider that fact a bug in homebrew.

Assuming it will not change, unfortunately, I'd be happy to manually test the x86 binary if you are concerned about the safety of distributing it to Apple Silicon machines. If it works, it would be safe to remove the Intel check for 0.2.x instead of back-porting support.

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

Oh! I see what you're saying about dropping the intel check.

from homebrew-tap.

mjpitz avatar mjpitz commented on September 22, 2024

I've removed this check for the arch in 0.2.x. Let me know if you still have issues.

from homebrew-tap.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.