Change color picker in demo site to support opacity about github-readme-streak-stats HOT 8 CLOSED

I could give this a go if it hasn't been taken?

from github-readme-streak-stats.

@IvoLondon That would be great! If you have any questions, feel free to ask!

from github-readme-streak-stats.

Possible implementation: https://jscolor.com/ (uses input element)

from github-readme-streak-stats.

I need your thoughts on something I just found out - in order to add the opacity controller , the colour needs to be in a RGBA format. The queries in request const imageURL = ${window.location.origin}?${query}; are encoded and passed, but I suspect that a HEX is expected instead. Would you be able to amend this on the backend side or should I find a way to convert it before the request is being made? @DenverCoder1

from github-readme-streak-stats.

@IvoLondon Making the query be in 6-digit HEX for opaque colors and 8-digit HEX for transparent colors would be the best. Although I haven't tried it, it seems like https://jscolor.com/ makes the value automatically in HEX, but the "#" will need to be removed (and the "FF" if it is 8 digits and ends with "FF").

from github-readme-streak-stats.

Alright, I will sort this out and I will let you know. I've created a pull request, in case you want to see the changes - #58 (not sure if it was supposed to be done, when I'm fully ready?). Thanks!

from github-readme-streak-stats.

Looks good, instead of "rgba" in the presets, you can use "hexa" to make it automatically use HEX.

from github-readme-streak-stats.

If you can't find a way to easily make it 6 digits when there's no transparency, it's perfectly fine to keep it as 8-digit HEX for all colors.

It should be pretty simple to convert it in the update function while reducing the params though.

from github-readme-streak-stats.