Git Product home page Git Product logo

Comments (12)

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

Thanks for the report!

I think this is a bug with GitHub itself.

I don't know why, but GitHub shows all years since 1969 on your profile page.

image

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

It is possible that you had the date set incorrectly on some commits that were pushed.

image

from github-readme-streak-stats.

adityadees avatar adityadees commented on July 17, 2024

It is possible that you had the date set incorrectly on some commits that were pushed.

image

yes, because I set the push date manually, and I purposely set it to 1969

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

What do you expect the result to look like instead? If the first commit was Dec 31, 1969, I'd say it is working as expected.

I could make it ignore commits in years before GitHub was launched for example. What do you suggest?

from github-readme-streak-stats.

adityadees avatar adityadees commented on July 17, 2024

What do you expect the result to look like instead? If the first commit was Dec 31, 1969, I'd say it is working as expected.

I could make it ignore commits in years before GitHub was launched for example. What do you suggest?

Dec 31, 1969 - Present
I think the total contribution should be counted from 1969 to 2021
this bug appeared when i added commit in 1969.
total contribution , current streak, and longest streak also don't count as well

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

The issue likely has to do with the way the contributions are fetched. For every year since the first year on the profile, it makes a request to that year's contribution graph. Since there are 52 years between 1969 and 2021, it needs to make 52 requests to GitHub. It is likely that some of these requests are getting blocked since they occur in close proximity.

I thought of doing the requests in reverse order to make it so recent commits will definitely show up (but not necessarily commits from 52 years ago.

Here is an example of that

image

Let me know if you have any ideas.

from github-readme-streak-stats.

adityadees avatar adityadees commented on July 17, 2024

try to run on local , this working fine
ac1

but not working on live
ac2

I think the problem is about response time. maybe the connection was closed before all data was loaded

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

That is exactly what I think the issue is. It stops loading data before getting to all 52 of the contribution graphs.

from github-readme-streak-stats.

adityadees avatar adityadees commented on July 17, 2024

That is exactly what I think the issue is. It stops loading data before getting to all 52 of the contribution graphs.

yes waiting for contributor to fix this issue xD

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

What should be done about it? Would probably have to completely change the way it works in order to request all of that data in a short amount of time from GitHub.

I could start by doing them in reverse order to make sure the current streak will be accurate, and most of the important data will be loaded.

Would it make sense to you if years between 1970 and 2008, let's say, get skipped when making the requests? That may fix the problem because it seems to me it would be very rare to put commits in those years.

from github-readme-streak-stats.

adityadees avatar adityadees commented on July 17, 2024

okay, it doesn't matter to me, but if we can fix this problem, in my opinion it's better

from github-readme-streak-stats.

DenverCoder1 avatar DenverCoder1 commented on July 17, 2024

With #23 I changed the way it gets the start year to use the account creation date from the GitHub API instead of reading the HTML of the profile page.

Because of this change, commits before the account was created don't get counted making this not an issue for now.

I will continue to think of other ways to get the contributions, but I believe the way I do it is the only way since it's not a part of the public API.

from github-readme-streak-stats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.