Consider unstable flag to make cjs files be treated as esm about deno HOT 6 CLOSED

There are already so much "unstable" flags available, that I would try to avoid another one, whenever possible.

But it would be very appreciable, if we could have a central detection mechanism -- including something similar to nodejs/node#50096 resp. its containsModuleSyntax check -- to prevent unnecessary duplication of this kind of decision-making.

Right now deno is handling this kind of detection/decision task at a few different places.

That's why I'm fighting in #22840 some node:worker_thread import related troubles, which look surprisingly similar to #22811, which you solved just recently.

Please could you take a scrutinizing look at my draft PR (#22841) to solve this issue in this other place as well. Nevertheless, a more general solution for the file type detection and more reliable unit tests for its proper application would indeed make a lot of sense in the long run.

from deno.

encourages people shipping and writing code that doesn't work with Node's resolution

Upon further reflection, what I said in my previous comment isn't as relevant to Deno because Deno already treats everything outside node_modules as an ES module, so someone could already develop an npm package without properly setting up their package.json for distribution for Node.

I opened #22945 that implements this behaviour without a flag.

from deno.

I would also prefer this to be handled automatically, same as Bun does, and for sure Node would also do this as soon they stabilize their experimental flag described here.

from deno.

Once Node does that then we'll also change the behaviour to align with Node, but doing non-standard Node behaviour for Node compat makes the ESM/CJS situation in the Node ecosystem worse and not better (encourages people shipping and writing code that doesn't work with Node's resolution). I understand it's convenient for apps to have this behaviour though, which is why this non-standard Node behaviour will most likely be behind a flag.

from deno.

In this particular case we just have to figure out, which kind of import format should be used for a particular file. This can be simply decided by 1. the suffix, 2. enclosing package.json metadata or 3. found ESM/CJS specific keywords within the file.

We just have to figure out one question: how to handle the given files in the most appropriate manner?

If none of this criteria fits, we can still fall back to some very old fashioned defaults...

A perfect emulation of all the faults, inflexibility and historic burden of node shouldn't be the goal. Concerning ESM support in particular, we should really try to handle these tasks simply better than in node and also strive for unchanged legacy code utilization in modern runtimes --i.e. the other side of compatibility and easy reuse -- wherever possible.

from deno.

I'm in the processing of writing a more extensive answer about this topic in #17650.

We have very likely slightly different opinions on this topic, but I really like the way how you tireless advocate for improvement and practical change! :)

from deno.