Git Product home page Git Product logo

Comments (3)

DennisSuitters avatar DennisSuitters commented on August 22, 2024

Apologies for not seeing this earlier.
</blockquote> is valid HTML, why would we need to convert them to other elements? I'm not sure I'm understanding why they would need to be. The indentation is controlled via CSS, granted the resulting output may look different than what's displayed in the editor, but keep in mind that the markup is styled in Summernote in such a way for legibility, despite how the markup may be styled if used to display the content elsewhere.

from summernote-cleaner.

CheckeredFlag avatar CheckeredFlag commented on August 22, 2024

The point is that for many years, html editors misused <blockquote> as the equivalent to the nonexistent <indent> and had nothing whatsoever about denoting a quote. As a result, you may have this horrid html:

<p>Some text</p>
<blockquote>
  <p>Indented text</p>
  <blockquote>
    <p>Indented even more</p>
  </blockquote>
</blockquote>

In legacy html, this markup is quite common and cleaning it up is a pain. I'm proposing adding an option to cleaner to convert this to something like:

<p>Some text</p>
<div class="indent">
  <p>Indented text</p>
  <div class="indent">
    <p>Indented even more</p>
  </div>
</div>

This could be styled via:

.indent {
  left-margin: 10px;
}

Hope this clarifies my suggestion. This does, of course, assume that the html does not contain any properly used blockquote tags which would need to be reverted back manually.

from summernote-cleaner.

DennisSuitters avatar DennisSuitters commented on August 22, 2024

The cleaner, mainly removes elements, mostly styles and classes, and non-html elements. I'm open to suggestions and PR's that can do stuff like validating markup, and possibly restructuring it according to what should be semantic.

from summernote-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.