Git Product home page Git Product logo

Comments (10)

kaiquegarcia avatar kaiquegarcia commented on August 22, 2024 2

@DiemenDesign done; @LoloDf I wrote your username there, alright?

from summernote-cleaner.

DennisSuitters avatar DennisSuitters commented on August 22, 2024 1

Sorry about that @KaiqueG it was around 3AM and way past time for sleep. Thanks for the PR, I've merged it. I hope that fixes this issue.

from summernote-cleaner.

kaiquegarcia avatar kaiquegarcia commented on August 22, 2024 1

@DiemenDesign don't worry, hehe.

from summernote-cleaner.

kaiquegarcia avatar kaiquegarcia commented on August 22, 2024

I got the same problem here: #42 . Your solution to the RegExp is better than mine.

from summernote-cleaner.

DennisSuitters avatar DennisSuitters commented on August 22, 2024

Sorry for the delay, exactly where do you want me to test changing the regex (ie. Line number).
I did however try changing what I thought was the closest regex to what you suggest changing, and it made no difference on my end.

from summernote-cleaner.

LoloDf avatar LoloDf commented on August 22, 2024

It was at line number 56.
However you replaced it in the last commit by (line 57-60) :

 tS=new RegExp('<'+bT[i]+'[^>]*>','gi');
            out=out.replace(tS,'');
            tS=new RegExp('</'+bT[i]+'[^>]*>','gi');
            out=out.replace(tS,'');

wich does replace only the tags and not the inner content

from summernote-cleaner.

DennisSuitters avatar DennisSuitters commented on August 22, 2024

Does it now work as you think it should, it does for me here?

from summernote-cleaner.

kaiquegarcia avatar kaiquegarcia commented on August 22, 2024

@DiemenDesign That's the problem I solved at #42 . It's the same solution but he made a single expression when I used two, hehe.

from summernote-cleaner.

LoloDf avatar LoloDf commented on August 22, 2024

Yes it's maybe better to take my correction for the next commit as it use only one instruction instead of two (same for the replace, I do it once instead of two)

from summernote-cleaner.

DennisSuitters avatar DennisSuitters commented on August 22, 2024

@LoloDf if you like feel free to do a PR with your changes, though you may want to grab the latest source as I've edited a lot of the formatting in the last hour or so.

from summernote-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.