All content always being removed on "clean" about summernote-cleaner HOT 2 CLOSED

The latest push update using changes via @DaniilVeriga seems to have fixed things on me end. Open a new issue if the problem persists.

from summernote-cleaner.

@StudioJunkyard, @gr0g, I've encountered the same problem and was about to submit a pull request with a slight change, but then had a deeper look at the cleaner button's handler:

click: function () {
    if ($note.summernote('createRange').toString()) {
        var text = cleanText($note.summernote('createRange').toString(), options.cleaner.newline);
        $note.summernote('pasteHTML', text);
    } else {
        // var text=cleanText($note.summernote().text(),options.cleaner.newline);
        // That is the initial idea for the pull request: .text() returns nothing
        var text = cleanText($note.summernote('code'), options.cleaner.newline);
        $note.summernote('code', text);
    }
    
    // irrelevant to the issue notification part
}

What bothers me:
Competely different behavior if anything is selected by user and if nothing is selected. As well, there is a difference with pasting.

If some text is selected, then $note.summernote('createRange').toString() returns already plain text, well, bypassing the cleaner logic at all. The cleanText() call looks redundant, because it is called on already plain text. So, the main plugin's cleanText() is just not applied in this scenario. A solution could be getting a range's HTML string (but not sure, it is possible) instead of getting plain text.

If no text is selected, then cleanText() is called on, seems, correct .summernote('code') (assuming my fix is applied). This scenario looks correct.

So, there is behavior ambiguity. On paste the plugin cleanse the text using cleanText(), but on the Cleaner button click the plugin is like "plain text maker". If it was the idea (although, I bet it was not), then it would be great to have this info in the readme and also I found (it looks so!) a solution for non-working .text().

So, this appears to be working:

click: function () {
    if ($note.summernote('createRange').toString()) {
        var text = $note.summernote('createRange').toString();
        $note.summernote('pasteHTML', text);
    } else {
        var text = $($note.summernote('code')).text();
        $note.summernote('code', text);
    }

    // irrelevant to the issue notification part
}

Submitted a pull request #29. Well, it is up to you to apply or not;)

Meanwhile, @StudioJunkyard, thank you for the nice plugin.

from summernote-cleaner.