Add explicit type parameters to ignore functions about fstoolkit.errorhandling HOT 5 CLOSED

Indeed they do. Did you mean that was relevant for the handling of this issue?

Edit: Of course, it is relevant in the sense that explicitly specifying the type to ignore would avoid that issue since it wouldn't compile.

from fstoolkit.errorhandling.

We can even enforce it as a compiler check using RequiresExplicitTypeArguments

Cool, I didn't know about that. But I don't think we should force this on users.

from fstoolkit.errorhandling.

A mistake I occasionally make is mixing up Async.Ignore and AsyncResult.ignore.

asyncResult {
  do! 
    tryDoSomething
    |> Async.Ignore
}

asyncResult {
  do! 
    tryDoSomething
    |> AsyncResult.ignore
}

These mean very different things!

from fstoolkit.errorhandling.

I fully support this as I've done this to regular ignore at my codebase at work. We can even enforce it as a compiler check using RequiresExplicitTypeArguments

For reference:

[<AutoOpen>]
module Operators =

  [<RequiresExplicitTypeArguments>]
  /// <summary>
  /// Ignore the passed value. This is often used to throw away results of a computation.
  /// </summary>
  /// <param name="value">The value to ignore</param>
  /// <typeparam name="'a">the type of value to expect, and ignore</typeparam>
  /// <returns>unit</returns>
  let ignore<'a> (value: 'a) = ignore<'a> value

This doesn't stop anyone from doing ignore<_> however. (I guess that would have to be solved with Linting/Analyzers)

from fstoolkit.errorhandling.

But I don't think we should force this on users.

Yeah I can see that being a bit aggressive

Mind submitting a PR for this?

from fstoolkit.errorhandling.