Git Product home page Git Product logo

Comments (8)

vmariano avatar vmariano commented on August 15, 2024

This will not be implemented.

from bill-tracker.

gvilarino avatar gvilarino commented on August 15, 2024

Why not? I mean, wasn't this what we discussed and is available in #29?

from bill-tracker.

vmariano avatar vmariano commented on August 15, 2024

Take in mind, this design + add and remove combined looks like this:
loquepidieron
The idea is don't add the concept of change and show the text as #29

from bill-tracker.

gvilarino avatar gvilarino commented on August 15, 2024

But we agreed that add and remove wouldn't show the side-by side interface, whereas change would.

I don't understand what you're implying.

from bill-tracker.

vmariano avatar vmariano commented on August 15, 2024

and what happen when you have add remove and change combined in the same section?
The last image, show this situation.

from bill-tracker.

gvilarino avatar gvilarino commented on August 15, 2024

I see your point. I'd say:

If change is present in the same paragraph as where either an add or a remove is present (or both, or multiple) then it makes sense to show a side-view element with all changes. If no change is present, then we could leave it as a simple add/remove.

So, basically change > (add || remove) in terms of what to display.

from bill-tracker.

vmariano avatar vmariano commented on August 15, 2024

That was the initial approach of #31 and #29 I leave it, because:

  • it's going to take more time introduce the concept of difference.
  • Is confusing in the scenario I describe it before.
  • it's going to take more time introduce the 2 actions of the same button.

To avoid start a infinite discussion because we can't be agree what is the best approach. Lets go with the #29 first, and then do a A/B test with the 2 approaches with #31

from bill-tracker.

gvilarino avatar gvilarino commented on August 15, 2024

Agree

from bill-tracker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.