Git Product home page Git Product logo

Comments (2)

demianriccardi avatar demianriccardi commented on August 16, 2024

this is tricky. The gt method is provided by the AtomGroupRole and the t attribute is provided by the PhysVecMVR role. HackaMol::Molecule consumes both roles, where as another group of atoms (bond, angle, dihedral) does not consume the PhysVecMVR role and does not have t.

Thus, when a molecule calls the gt method, it changes the t for all atoms, but not itself. I think gt for Molecule should indeed set the t on itself.

from p5-hackamol.

demianriccardi avatar demianriccardi commented on August 16, 2024

After taking a closer look, I think leaving it as it is makes sense. The t attribute calls gt for a molecule. So the molecule t method will set itself and all atoms within the molecule. when using molecules use t for everything. Trying to set t from the gt call will fall into an endless loop of despair.

from p5-hackamol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.