Git Product home page Git Product logo

Comments (12)

demberto avatar demberto commented on July 1, 2024 1

@all-contributors please add @zacanger for bug

from pyflp.

demberto avatar demberto commented on July 1, 2024

Make sure you use parse_zip if you want to parse an FLP in the ZIP.

You are the first user of my library probably, thanks its motivating :))

FLPInspect is botched up, its pending an entire rewrite, so currently its unuseable.

from pyflp.

SilasNiewierra avatar SilasNiewierra commented on July 1, 2024

Hi @demberto , thanks for the response.
I'm not working with a zip.
I have an .flp file in the same directory and want to analyze that with PyFLP.
This is all the code I have so far πŸ˜„ you can see the file structure and error message as well.
image

from pyflp.

demberto avatar demberto commented on July 1, 2024

Hmm, you encountered a bug. Can you attach the FLP here please?

from pyflp.

SilasNiewierra avatar SilasNiewierra commented on July 1, 2024

I think I found the reason, or another bug 😁
I tried to recreate the problem by creating an empty file (which works πŸ‘ ) and then add plugins and samples till I reach the .flp which was broken.
I found out that if you drag a MIDI file onto a channel, your analyzer will crash with:
image
Since both of the errors have that 128 in them, I suspect they both come from the same issue.

from pyflp.

demberto avatar demberto commented on July 1, 2024

Ok, another bug. But this is not related to the first one at all. The MIDI channel limited to 15 are the 16 colors you can choose for your notes. Now it seems there's another use case for them too. I will try to reproduce this issue, if I can't maybe you can send me the test.flp?

The GUID error you ran with earlier, it is exclusively used by Waves plugins AFAIK. Can you check your warm.flp for any Waves plugins?

I think this definitely makes a point to improve the error handling. I could add more info about what insert or channel failed to parse for example.

from pyflp.

SilasNiewierra avatar SilasNiewierra commented on July 1, 2024

Hi there,
I was able to get what I wanted by using node.js and a custom flp-parser library.
However, regarding this issue: I didn't use Waves plugins for the test file but kHS Plugins and two Serum instances.
I hope this helps πŸ˜„

from pyflp.

tochibedford avatar tochibedford commented on July 1, 2024

Hey! ran into same issue when I opened 1 flp but didn't occur for other flps:
Screenshot 2022-07-09 at 03 03 45

Also I should note, I just spent the last 4 hours writing a parser so I could quickly look through the samples used in an flp, only to find out someone already did it (you), so thank you! Is there anyway to reach you besides github?

from pyflp.

demberto avatar demberto commented on July 1, 2024

@tochibedford I will fix this issue ASAP. You can reach me via email: [email protected]. I check my mails often so I reply as soon as I can generally :)

from pyflp.

demberto avatar demberto commented on July 1, 2024

@tochibedford @SilasNiewierra Please test your FLPs with v1.1.1, I have fixed both issues

You can run

pip install --upgrade pyflp

to update to PyFLP 1.1.1

from pyflp.

demberto avatar demberto commented on July 1, 2024

Closing this issue due to lack of response, bugs fixes in v1.1.1

from pyflp.

allcontributors avatar allcontributors commented on July 1, 2024

@demberto

I've put up a pull request to add @zacanger! πŸŽ‰

from pyflp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.