Comments (2)
I think this is exactly the reason why we decided to put that big fat warning in there. The client is not guaranteed to work with older releases, and we highly recommend upgrading in lock-step, but occasionally older clients can be used to talk to newer servers since the API shouldn't change significantly.
That being said, I don't see any reason why this would be broken according to deis/controller@v2.0.0...v2.1.0. The only relevant change I've seen server-side is in deis/controller@46829d3 and that was in 2.0.0-alpha, so I'm at a loss how a 2.1 client would fail to save the token from a 2.0 server. I'll see if I can replicate :)
from workflow-cli.
Ok. I figured out the problem.... I screwed up 😦. When the request returns a version mismatch, it returns that error in addation to the response. When the methods get the error response they immediately bail out and don't attempt to parse the body.
The CLI on the other hand, checks to see if the error is an API mismatch, and if there is, recognizes it is a warning and continues on, even though they're only working with a blank object.
What the SDK should do is implement a method similar to the workflow-cli's checkAPICompatibility which checks if the the error is an api compatibility one before bailing out.
from workflow-cli.
Related Issues (20)
- Buildpack for Ruby fails to parse a particular syntax HOT 3
- use go-rootcerts to support custom PKI on darwin HOT 3
- deis config should handle base64 encoded SSH_KEY
- master branch not building; codecov issue? HOT 1
- Custom HTTP-Headers for Readiness-Checks ignored HOT 2
- Support Heroku app.json file HOT 2
- config:push with .env doesn't handle export or double quotes HOT 4
- feat(client): Teach option flag for tracing requests HOT 2
- config:push with .env does not support multline HOT 11
- Publisher fails to parse HEALTHCHECK_INITIAL_DELAY if the value contains `\r` HOT 2
- Add config:diff
- deis create in a non-git directory should run with --no-remote HOT 5
- [Feature request] Automatic deis profile selection based on git remote HOT 1
- Move workflow-cli binaries to Azure Blob Storage HOT 1
- Get rid of stdin for deis config:push HOT 2
- Consider disabling automatic Procfile lookup for deis pull HOT 2
- apps:destroy should have a more explicit help message HOT 5
- deis releases returns requested URL not found HOT 5
- deis registry:unset unauthorized HOT 4
- Url : permission denied HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from workflow-cli.