add mock k8s tests about controller HOT 7 CLOSED

👍. Such a library could be modeled after the Go on in Helm: https://github.com/helm/helm/tree/master/kubectl.

from controller.

Closed by #497

from controller.

Reopening this since I think we may need to inspect a bit more closely what we add to k8s. Right now we use a very basic mock but in many cases it would at least give us a decent idea of what we are applying based on various configs and otherwise.

Thoughts on how we should go about this?

from controller.

@helgi In the past few sprints I know you've worked on these mocks, are they sufficient enough to close this issue now?

from controller.

I haven't been happy enough with those - They prove certain interactions but not enough introspection on the built payload, et all. When we do more of that then I'd consider this done

from controller.

I updated the core description with some additional information.

One thing to note is functions like manifest in each resource we do not test directly but rather rely on create and update to call it with the right things. As such there is no introspection at that level on what is being sent... That could be a good addition overall, to compare to that directly since that's what is sent to Kubernetes... Thoughts?

from controller.

Going to close this - We have very good coverage, mostly 70% and higher. In many cases 85% will be hard to achieve due to the mocking not being smart enough to create more delays etc to exercise some of the wait code

from controller.