Integrate app level configuration with k8s about controller HOT 12 CLOSED

@helgi do you happen to have a checklist handy of all the resources we need to imitate in the controller for the router? I know we've tackled domains, but I guess app config like IP whitelisting and certs still need to be done.

from controller.

@bacongobbler see annotation reference in https://github.com/deis/router#annotations

The four app-level things that can be tweaked at present are domains, connect timeout, read/write timeout, and whitelists.

from controller.

Certificates were the only thing on my list so far - We may be able to pull Config over and use that as a way to cover for IP whitelisting and such. Shouldn't be hard if we come up with a convention (emulated deis.io/routerConfig)

I know that is a bigger scope than router but might be worth it

from controller.

We don't need to concern ourselves with certs for alpha.

from controller.

Agreed but I may start work on that so the workflow side of it is done before we touch the router itself

from controller.

Removing showstopper label since this is a broader ticket

from controller.

If this is broadening to that level, the alpha milestone on the ticket is wrong. I'm thinking we need separate issues for achieving the minimum functionality required for alpha and then anything else that's for beta and beyond.

fwiw... I just realized the controller does not need to add any support for setting timeouts, even though the router supports it. v1.x did not have this feature and the only reason I added support for this to the router itself was that it allowed me to treat the controller as "just another app." (Controller itself needed those values tweaked-- see the chart-- but does not need to manage them on other apps in order to achieve feature parity.)

https://github.com/deis/charts/blob/master/deis/manifests/deis-workflow-service.yaml#L13-L14

from controller.

So if workflow can handle whitelists, we're in decent shape.

from controller.

yeah I imagined this was a post-alpha milestone. Not something we need to tackle today if the basic workflow is good (deis open)

from controller.

This is on the beta list, but it's not clear to me what is left to do. Can someone update a status on it? And maybe assign it to themselves?

from controller.

The IP whitelist is not really done but we haven't really planned it either. Not have we figured out how we want to do configuration changes (if at all) that affect other deis components, ala deisctl.

Removing it from beta for now but we need to get to this and make decisions sooner or later

from controller.

Closing this since we got all the items above, last one was IP Whitelist, and we have a way we like (so far) to modify things like the router, etc

from controller.