Git Product home page Git Product logo

Comments (8)

NMontanaBrown avatar NMontanaBrown commented on May 30, 2024 1

Also @mathpluscode what do you mean by init(config) here: "In init(config_path, log_dir, ckpt_path): the config will be copied into the log folder, so that in the prediction it will take the backup config to make sure the config is consistent."?

Can you point me to the source code? That way I might understand better

@YipengHu I think you have to force push, which could be quite troublesome to everyone else working on this fork, so don't worry about it. Ideally we push to develop on forks so if there is some sort of problem like this it doesn't change the base repo, or can just force push on that repo which doesn't affect this one until merge, or create a new branch to redevelop with the right messages.

from deepreg.

mathpluscode avatar mathpluscode commented on May 30, 2024 1

ok, i think what @NMontanaBrown wanted is the option to allow to not use the default config, it should be done easily.
will do it tonight, then we close this

from deepreg.

mathpluscode avatar mathpluscode commented on May 30, 2024

In init(config_path, log_dir, ckpt_path): the config will be copied into the log folder, so that in the prediction it will take the backup config to make sure the config is consistent.

I didn't ask the predict to take a config as input as it might be inconsistent

from deepreg.

NMontanaBrown avatar NMontanaBrown commented on May 30, 2024

I'm not sure I understand where that init line of code comes from, can you provide a link?

from deepreg.

NMontanaBrown avatar NMontanaBrown commented on May 30, 2024

@YipengHu Can you change the refs for the commits? They point to the wrong ticket.

from deepreg.

YipengHu avatar YipengHu commented on May 30, 2024

@YipengHu Can you change the refs for the commits? They point to the wrong ticket.

I noticed too - really embarrassing, was not sure how to do it...

from deepreg.

mathpluscode avatar mathpluscode commented on May 30, 2024

sorry for the delay, so if i understand correctly, we want the prediction to accept a configuration file separately,

what i did now, as you mentioned, is assuming a relatively strict structure of the code, which is consistent with the training script

what we can do is

  • support additional config file
  • raise error if failed to load the checkpoint, as now we still need to build the model then load the weights

another method is

  • save the model structure so that we only need data set and checkpoint to do prediction

from deepreg.

YipengHu avatar YipengHu commented on May 30, 2024

@mathpluscode @NMontanaBrown is it still a relevant issue? better to close this and open new one with specific tasks.

from deepreg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.