Git Product home page Git Product logo

Comments (4)

ded avatar ded commented on June 16, 2024

how are you concatenating your scripts? why not just files.join(';')

from reqwest.

igorw avatar igorw commented on June 16, 2024

Seriously? I'm using assetic. But I imagine this to be an issue with almost any concatenation script.

from reqwest.

deoxxa avatar deoxxa commented on June 16, 2024

Doesn't seem to cause a problem with ender. Nor does it cause an issue with the in-house stuff I use at work (which pretty much does what @ded mentioned). I've also not seen any problems with the system that the SilverStripe CMS uses.

Being snarky isn't a great way to get bugs fixed.

from reqwest.

igorw avatar igorw commented on June 16, 2024

Sorry, I did not mean to be rude.

The thing is that assetic does not know what kind of files it's dealing with. It just knows that it should concatenate these files and apply a set of filters. This allows it to be used with CSS as well. Is there any reason not to have the semicolon.

It's nice that you add the leading ! to prevent this issue for scripts added before reqwest.

from reqwest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.