Phone number in International format about mrim-prpl HOT 23 CLOSED

Mail.ru Agent Protocol uses phones number without '+'.
So, At this moment '+' is trimmed now.

And it is possible to save usersettable aliases.

brunch/mrim-prpl-0.1.27.1-r106 doesn't trim phone *number* (but trims '+')

I never send sms to international phone numers, and I don't know how it is 
works in MailAgent and in the plugin

I gonna confirm that: please refer to http://agent.mail.ru/ to find out which 
countries are supported when sending SMS messages to phones from. Keep in ming 
that mrim-prpl module uses standard SMS sending service provided by @Mail.Ru 
corporation.

Note that when you want to store phone number of your contact, and that number 
does not belong to anyone of the countries supported by @Mail.Ru SMS 
transmission service, you are free to use gtkbuddynote plugin instead.

It stores numbers without '+' sign there in @Mail.ru network itself, it's not a 
feature of mrim-prpl.

Even if we remove + sign, what about last digit?

You use the last one revision, don't you?

mrim-prpl 0.1.27,
pidgin 2.7.3
ubuntu 10.10

Janus.Kobain.Stamp, собери из svn /brunch/mrim-ptpl-0.1.27.1 - там 
не будет обрезать 12-ю цифру... но я не в 
курсе, как на длинные телефоны отреагирует 
агент.

[deleted comment]

[deleted comment]

Is line #87 of mrim.c, "g_return_val_if_fail(length == 11, FALSE);" is valid 
for 12 digit phone numbers? Or should it be "g_return_val_if_fail(length == 12, 
FALSE);"

Ya ustanovil r106, no vse ravno obrezayet 12-yu cifru.

Фикс из комментария #12 попал только в 
branches/mrim-prpl-0.1.27.1-r107 (в trunk-е всё по-старому... 
со следующим комитом поправлю)

on line #87 of mrim.c, change "length == 12" to "(length == 11) || (length == 
12)"

thanks. r115

Updated to mrim-prpl_0.1.27rc.r115, but now editing phone numbers is not 
accepting any numbers. Here is debug info from pidgin:
(16:01:25) mrim: [blist_edit_phones] 998931848323 (null) (null)
(16:01:25) mrim: [clear_phone] <998931848323>
(16:01:25) mrim: [mrim_phones_to_string] <>
(16:01:25) mrim: Отправил пакет len=<98>
(16:01:25) mrim: [mrim_input_cb]

Работает в последнем 0.1.27.1
Баг будет закрыт после тестирования trunk-а

Транк после этого, получается, станет branch 
0.1.27.2, а сам обретёт версию 0.1.27.3?

как транк станет стабильным - будет релиз 
0.1.28

думаю, это будет релиз 0.1.28

Как вижу, не стант ещё долго.