Git Product home page Git Product logo

Comments (4)

aarondill avatar aarondill commented on July 18, 2024

I'm happy to submit a PR with either of the above patches (or another) if you would like

from tilp_and_gfm.

debrouxl avatar debrouxl commented on July 18, 2024

Thanks for the report. It's interesting that this one doesn't get reported more often... do you have multiple versions of libti* in your LD_LIBRARY_PATH ?

Running TILP with outdated library dependencies is a fatal error, in that a subset of the functionality will be unavailable. Since there's a need to fiddle with the library version checking code anyway... I think that the right way to fix this is to use a proper version comparison routine (which strcmp() isn't: 1.1.10 < 1.1.9), and report all outdated libraries in one go, before exiting the program cleanly.

from tilp_and_gfm.

aarondill avatar aarondill commented on July 18, 2024

does C / GTK supply a version checking function? I tried a google search and couldn't find anything that looked promising?

from tilp_and_gfm.

debrouxl avatar debrouxl commented on July 18, 2024

There had to be a version comparison routine in package managers or below sort -V. A little digging around returns https://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/strverscmp.c and https://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/filevercmp.c , both of which are generic... but eww, all the more portability concerns mandate integrating a local copy of these LGPL'ed functions.

For simple version numbers made of 3 numeric elements, sscanf() would work... that is, if it handled numeric overflow correctly. I was reminded by comments on StackOverflow that it doesn't...

from tilp_and_gfm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.