Comments (8)
And numpy-ml/numpy_ml/neural_nets/wrappers/wrappers.py
Line 207:
your code
def backward(self, dLdy, retain_grads):
"""
retain_grads: Default is True
"""
Your code is missing the default value, resulting in an error at numpy-ml/numpy_ml/neural_nets/layers/layers.py
Line 332.
from numpy-ml.
And numpy-ml/numpy_ml/neural_nets/layers/layers.py
Line 2116:
your code
def backward(self, dLdy):
"""
retain_grads: Default is True
"""
The function in your code is missing an argument retain_grads
, resulting in an error at numpy-ml/numpy_ml/neural_nets/wrappers/wrappers.py
Line 227.
from numpy-ml.
Maybe I should fork and create pull request 😃
from numpy-ml.
And numpy-ml/numpy_ml/neural_nets/tests/tests.py
line 510:
your code
from ..activations import Softmax
but
Softmax
is not implemented in ..activations
, but in ..layers
.
right code
- line 510:
from ..layers import Softmax
- line 527:
y_pred = sm.forward(z)
from numpy-ml.
And numpy-ml/numpy_ml/neural_nets/tests/tests.py
line 771:
your code
from ..activations import SoftSign
but SoftSign is not implemented in ..activations
.
maybe you should delete function test_softsign_grad
and test_softsign_activation
.
from numpy-ml.
@Z-zhe - Wow, thanks so much for all these! I haven't had a chance to take a look yet, but should have some time this weekend. In the meantime if you feel like submitting a PR with fixes I'd be happy to review it, otherwise I can try to address these shortly.
from numpy-ml.
PR is complicated, it is easier for you to modify. 😃
from numpy-ml.
numpy-ml/numpy_ml/neural_nets/layers/layers.py
line 2341:
your code
dX = dZ @ W.T
I don't think it should be W
it should be W_sparse
. So I think right code should be:
dX = dZ @ W_sparse.T
Please reconsider,thanks.
from numpy-ml.
Related Issues (20)
- Using numpy.tensordot for Conv2D HOT 1
- error in DecisionTree
- Bug in transfer learning
- Bug in initializers init_from_dict()
- [Question] Gradient of Gradient Penalty in WGAN-GP.
- Naive Bayes HOT 3
- Feature Request: Clustering Kmeans (hard and soft version) HOT 2
- Feature Request: Online Linear Regression HOT 7
- Feature request: Accept multiple samples for online least squares HOT 1
- Best choice for my use case? HOT 1
- `numpy_ml.linear_model.LinearRegression.predict()` generates `ValueError` when used with copy-pasted code, but pip installed version works as expected!! HOT 1
- neural nets optimizer shape mismatch during backward pass
- Import of collections.Hashable fails in Python 3.10 HOT 3
- Columns and DataType Not Explicitly Set on line 228 of rl_utils.py
- Feature request: save/load model to/from json
- Question to improve the code.
- Declare your version of modules
- Automatic diferentiation for neural networks
- no 'load_dataset' in numpy_mL
- Example of MLP architecture
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from numpy-ml.