Git Product home page Git Product logo

Comments (2)

rurounijones avatar rurounijones commented on June 4, 2024

Generally I would go with the simplest thing and just prefix like net_getPlayers.

However in this particular case I wonder if we shouldn't instead change the API names to be a bit more specifically accurate. coalition.getPlayers was named as such because that was the ED name.

However, especially in light of the conflict above, I wonder if we should rename this to coalition.getPlayerUnits since it is actually a more accurate representation of the data being returned which is in contrast to the data being returned by net.getPlayers which is more about the player than the unit.

from rust-server.

justin-lovell avatar justin-lovell commented on June 4, 2024

I wonder if we should rename this to coalition.getPlayerUnits since it is actually a more accurate representation of the data being returned which is in contrast to the data being returned by net.getPlayers which is more about the player than the unit.

Good observation. I will integrate that in a PR to come shortly.

This morning, I thought of a lightweight solution to detect conflicts in registration. What if we had functional registrations such as

GRPC.registerMethod('theMethodName', function(params)

end)

If there is already another method, deregister both methods. That way the person who is writing a new function would be forced to acknowledge the duplication.

The only other alternative is to perform a full regression test suite, which is very heavy given for full confidence, we need to launch DCS on a CI build (ouch!)

from rust-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.