Comments (2)
Generally I would go with the simplest thing and just prefix like net_getPlayers
.
However in this particular case I wonder if we shouldn't instead change the API names to be a bit more specifically accurate. coalition.getPlayers
was named as such because that was the ED name.
However, especially in light of the conflict above, I wonder if we should rename this to coalition.getPlayerUnits
since it is actually a more accurate representation of the data being returned which is in contrast to the data being returned by net.getPlayers
which is more about the player than the unit.
from rust-server.
I wonder if we should rename this to
coalition.getPlayerUnits
since it is actually a more accurate representation of the data being returned which is in contrast to the data being returned bynet.getPlayers
which is more about the player than the unit.
Good observation. I will integrate that in a PR to come shortly.
This morning, I thought of a lightweight solution to detect conflicts in registration. What if we had functional registrations such as
GRPC.registerMethod('theMethodName', function(params)
end)
If there is already another method, deregister both methods. That way the person who is writing a new function would be forced to acknowledge the duplication.
The only other alternative is to perform a full regression test suite, which is very heavy given for full confidence, we need to launch DCS on a CI build (ouch!)
from rust-server.
Related Issues (20)
- Re-use SRS connections
- Add a TTS API to indicate channel in use
- Add SRS client connected/disconnected/freq-changed events HOT 1
- Pre-built proto files
- Errors when getting group name of a unit, leading to no stream kill events HOT 6
- Weapon & Ballistics stream HOT 1
- Custom error handling for: attempt to index global 'grpc' (a nil value) HOT 1
- Create one-click installer HOT 3
- attempt to call field 'simulationFrame' (a nil value) HOT 5
- Failed to deserialize event: deserialize error: missing field `u` HOT 3
- MarkAdd and MarkChange event payload arrives without mark position HOT 4
- User Error HOT 1
- Error using a config file for TTS HOT 10
- Hooks DCS-gRPC.lua - file not closed after reading HOT 2
- TTS glcoud voice option is ignored HOT 2
- support for AWS Instance Profiles HOT 4
- Error in mission.lua due to DCS API getCategory behaviour change HOT 3
- Unnecessary filtering on english voices in windows TTS? HOT 2
- Feature request: TTS only version HOT 4
- Shot events not registering HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-server.