Detecting overflows... about long.js HOT 6 CLOSED

Your solution looks OK to me. There is no analogy between Number.MAX_SAFE_INTEGER and Long.js though, as this constant rather indicates precision loss for greater magnitudes due to JavaScript numbers being doubles internally.

from long.js.

How to know if it overflows after it is a Long object?

> Long.fromString("0").add(Long.MAX_VALUE).toString()
'9223372036854775807'
> Long.fromString("1").add(Long.MAX_VALUE).toString()
'-9223372036854775808'

from long.js.

It overflows like any other (64 bit) two's complement integer.

from long.js.

Interesting ... I'm guessing here, but I'm starting to think that overflows may be a case-by-case scenario. If so this may mean that Long.js is ideal for ByteBuffer but that I may need to go to a larger number library like bn.js for what I'm trying to do. In this way, I can overflow 64 bits getting the correct answer but checking my final result to see if it exceeds the 64 bits. I believe you mentioned bn.js. Is that not over-kill though for 64 bits? Do you think your library will be more efficient for these?

from long.js.

Unfortunately, I am not familiar with the bn.js codebase and don't know how efficient it is, but it might be an option if you need to work with more than exactly 64 bits of information (or a change of sign is not a good enough indicator for an overflow).

from long.js.

Ok, so "not supported" ... I think, if supported, overflow detection would need to be internal to the library and performed on all operations. I will use a large number library instead so I can work it out on my side. Thank you...

from long.js.