More consistent use of PHP return types about robohome-web HOT 7 CLOSED

Would love to help out, will do a search and see what comes up

from robohome-web.

Awesome! Should be pretty easy :). Mainly just need to add void and array to the end of some function signatures and take away a space after the name of the function and the colon. Let me know if you have any questions.

from robohome-web.

Regarding the format of return types, since most of the code used function() : type format I went with it, there are a lot of occurrences to be replaced throughout the code-base

from robohome-web.

Perhaps best if a separate PR was made to address the above issue

from robohome-web.

Correct. The intent was to change the occurrences with the space, to the version without. The reason being is that it's more consistent with the PHP docs and also it's how PhpStorm generates function names with return types automatically.

I would prefer maybe just a separate commit instead of another PR.

I'm getting ready to merge an already open PR when I finish the review in a minute so a rebase will be needed but luckily the rebase should be pretty straightforward.

from robohome-web.

Already made the commit, sure rebase is not a problem

from robohome-web.

Completed in #96 and due to the closing of #100. Thank you @michaeltintiuc.

from robohome-web.