Comments (4)
nicor88
commented on June 12, 2024
@chrischin478 could you try to propose a fix based on your finding?
from dbt-athena.
chrischin478
commented on June 12, 2024
@nicor88 I've included the proposal in the description. Let me know what you think.
from dbt-athena.
nicor88
commented on June 12, 2024
I've see it, I think is fine to try out what you suggested - that's why I wrote to try to propose a PR, because we can actually verify via functional tests that all works fine.
Looking at dbt-core code seems that the use md5(self.project_name), but what you suggested:
from dbt.utils import md5
@property
def unique_field(self) -> str:
return f"athena-{md5(self.s3_staging_dir)}"it's totally fine for me.
from dbt-athena.
chrischin478
commented on June 12, 2024
Great! I'll get a PR started.
…On Thu, Mar 14, 2024, 6:31 PM nicor88 ***@***.***> wrote:
I've see it, I think is fine to try out what you suggested.
Looking at dbt-core code seems that the use md5(self.project_name), but
what you suggested:
from dbt.utils import md5
@propertydef unique_field(self) -> str:
return f"athena-{md5(self.s3_staging_dir)}"
it's totally fine for me.
—
Reply to this email directly, view it on GitHub
<#602 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALIDJQXBQOFPRZFDJKS6WLDYYIQKZAVCNFSM6AAAAABEWORNZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGU4DQNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from dbt-athena.
Related Issues (20)
- Upgrade to support dbt-core v1.8.0 HOT 1
- [Bug] `truncate()` partition transformation does not work when it includes more than 100 partitions HOT 1
- Bug Hitting `ThrottlingException` on `GetWorkGroup` with threads turned up HOT 5
- [Bug] Iceberg table materialization shouldn't s3_data_naming=table
- [Bug] Resolution failure for `create_table_as` macro when upgrading to 1.7.2 HOT 1
- upgrade to support dbt-core v1.8.0 HOT 6
- [Feature] Control glue database/schema for tmp tables generated by incremental models HOT 1
- [Bug] force_batch deletes data from model_tmp_not_partitioned before coping to the final table HOT 2
- [Feature] Rename unique_key to unique_columns or merge_on_columns HOT 3
- [Feature] Support configurable management of Table Optimisers for Iceberg tables HOT 3
- [Bug] Error when Python Model Goes To Write To Database HOT 14
- [Feature] Custom strategy for incremental models when table type is iceberg
- [Bug] dbt source freshness expected a timestamp but received a string HOT 2
- [Feature] Athena dbt-external-tables impl as independent package HOT 5
- [Bug] Clone materialization raises an error when cloning Python models HOT 2
- TABLE_NOT_FOUND Error During Unit Testing in dbt-athena 1.8 Due to Jinja Macro Dependency HOT 3
- Hive vs Iceberg timestamps in unit tests HOT 4
- [Bug] TABLE_NOT_FOUND {{tmp_relation}} when there are zero batches to process in incremental model HOT 1
- [Feature] Allow to define a different schema for tmp tables created during table materialization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt-athena.