Vertical flat separator about telephone-line HOT 9 CLOSED

This is technically working as intended -- telephone-line-height is working fine, but the default width of all separators is 1/2 their height. I do agree, however, that this shouldn't be the case for nil.

from telephone-line.

Turns out this was actually a different issue -- nil had a division by zero (the zero being the range of values).

Latest commit makes the nil separator a subclass which bypasses the rendering code to just return nil. Let me know if this works better.

from telephone-line.

@dbordak, nope, all the same. Damn, forget that isn't the recent update from MELPA.

UPD: By the way, the most latest git version doesn't fix this behavior.

from telephone-line.

Oh, just realized what the issue actually is...

So, telephone-line-height only changes the height of the separator images -- no other way to influence mode-line height. If I'm not rendering any images, there's no way to control the height of the mode-line.

from telephone-line.

Ok, latest commit finally fixes this. Test it out and let me know for sure.

from telephone-line.

I might rename this separator in the future since it's no longer a noop (if I do, I'll include the old nil separator under this name). I guess telephone-line-flat?

from telephone-line.

The 6789e79 fixes the issue, works as excepted. Thanks. Now the issue can be closed.

I might rename this separator in the future since it's no longer a noop (if I do, I'll include the old nil separator under this name). I guess telephone-line-flat?

Yes, telephone-line-nil is not obvious for me, so that's a good idea to rename it. telephone-line-flat is fine.

Also would be nice if you add info about this separator to README.md.

from telephone-line.

Yeah, I'm going to do the rename and update the README. Only reason it wasn't already there is because... well, there's nothing to look at (the separators shown there are all taken directly from telephone-line -- they're the internal XPMs converted to PNGs, not screenshots).

from telephone-line.

Alright, it's been renamed.

from telephone-line.