data-* attribute giving "Unknown HTML attribute(s)" about re-com HOT 6 CLOSED

Yes, you are certainly correct about both of those attributes. I will not be able to get an opportunity to work on this for a while. If you end up making the changes yourself, we'd be happy to incorporate your code.

from re-com.

Hi, I began working on a pull request and while doing so I ran into the problem of validating XML attribute names. According to the W3 spec here http://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes the data-* attribute has to be a valid XML attribute name (not surprising, I guess). I tried implementing the naming spec here http://www.w3.org/TR/REC-xml/#NT-Name using a regular expression, but then found it was exceptionally painful due to JavaScript's poor support for Unicode characters in regular expressions. I could implement it without using a regular expression, but I thought it might be a good idea to ask whether you think it's even worth it to do so, or is it good enough to just make sure the the attribute starts with data- and has one or more characters after that?

Thanks, and apologies for the bikeshedding

from re-com.

The goal with this validation is to help a programmer catch problems early. Misspelling something can take a surprisingly long time to find sometimes.

So we want to be as helpful as we can be, but not tie ourselves in knots doing it ;-)

In which case, I think checking for data-* and waving it through as vailid is fine by me.

from re-com.

@meowcakes checking: given you have closed this, are you then working on a patch to wave data-* through as valid?

from re-com.

Yup, pull request opened here #13

from re-com.

Thanks!

from re-com.