Regression in 0.15.1 (when used in browser context) about live-plugin-manager HOT 6 CLOSED

The problem is the assumption that the current console object is the NodeJS object. For example if you use a log framework as electron-log the Console costructor don't exists.

A simple patch ( work in my case ) is:

@@ -435,7 +437,12 @@ export class PluginVm {
 			sandbox.process = Object.create(srcGlobal.process || null);
 		}
 		if (!sandbox.console) {
-			sandbox.console = new console.Console({ stdout: process.stdout, stderr: process.stderr });
+			if(console.Console){
+				sandbox.console = new console.Console({ stdout: process.stdout, stderr: process.stderr });
+			} else {
+				const { Console } = require('console');
+				sandbox.console = new Console({ stdout: process.stdout, stderr: process.stderr });
+			}
 		}
 
 		// override the global obj to "unlink" it from the original global obj

from live-plugin-manager.

Can you try to execute that on your environment?

console.Console({ stdout: process.stdout, stderr: process.stderr }); 

As described here: https://nodejs.org/docs/latest-v12.x/api/console.html#console_new_console_stdout_stderr_ignoreerrors

I suspect that console is not available in Electron or something similar. I'm not expert about Electron. Which node version are you using? Electron uses a built-in version?

thanks

from live-plugin-manager.

I believe latest Electron bundles Node 12.16.3. Thanks, I’ll look into it

from live-plugin-manager.

Thanks @dianlight ! Do you want to create a PR?

from live-plugin-manager.

It would be great to have some sort of unit test or example to reproduce this problem...

from live-plugin-manager.

@davideicardi now I don’t have much time. I will see what I can do.

from live-plugin-manager.