Git Product home page Git Product logo

Comments (4)

David-Desmaisons avatar David-Desmaisons commented on May 18, 2024

You do not need to wait for the call completion:

for (int i = 0; i < 1000; i++)
        {
            await timeconstraint.Perform(ConsoleIt);
        }

 private void ConsoleIt()
    {
        Console.WriteLine(string.Format("{0:MM/dd/yyy HH:mm:ss.fff}", DateTime.Now));
        Thread.Sleep(3000); //simulate api call made and waiting for response. 
    }`

from ratelimiter.

inventivethinking11 avatar inventivethinking11 commented on May 18, 2024

Thanks for the response.

But this does not seem to solve the problem. If you happen to execute this code, the system only makes a single call and waits until that finishes and starts next call.

`
public async Task Start()
{

        //Create Time constraint: max five times by second
        var timeconstraint = TimeLimiter.GetFromMaxCountByInterval(5, TimeSpan.FromSeconds(1));
        //Use it
        for (int i = 0; i < 1000; i++)
        {
            await timeconstraint.Perform(ConsoleIt);
        }

        return true;
    }
    private Task ConsoleIt()
    {
        Console.WriteLine(string.Format("{0:MM/dd/yyy HH:mm:ss.fff}", DateTime.Now));
        Thread.Sleep(3000); //simulate api call made and waiting for response. 
        Console.WriteLine("Finished");
        return Task.FromResult(0);

    }

`

from ratelimiter.

David-Desmaisons avatar David-Desmaisons commented on May 18, 2024

Note that in my example, I was using a signature with a void return and not a Task, this is key here not to wait to the completion of the task.
So:

for (int i = 0; i < 1000; i++)
        {
            await timeconstraint.Perform(ConsoleIt);
        }

 private void ConsoleIt()
    {
        Task.Run(() => {
         Console.WriteLine(string.Format("{0:MM/dd/yyy HH:mm:ss.fff}", DateTime.Now));
        Thread.Sleep(3000); //simulate api call made and waiting for response. 
     });
}

from ratelimiter.

inventivethinking11 avatar inventivethinking11 commented on May 18, 2024

Oh you are right. I didn't notice, that solved the issue.

Thanks!

from ratelimiter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.