Laravel 5 Compatibility about laravel-push-notification HOT 19 CLOSED

I havent played with laravel 5 yet, can you fork the repo and upgrade illuminate/support version constraint to "4.|5." and see if its ok?

from laravel-push-notification.

I'll take a peak this weekend for ya.

Sent from my iPhone

On Feb 5, 2015, at 5:22 PM, Davi Nunes [email protected] wrote:

I havent played with laravel 5 yet, can you fork the repo and upgrade illuminate/support version constraint to "4.|5." and see if its ok?

—
Reply to this email directly or view it on GitHub.

from laravel-push-notification.

To allows L5 support, need to change come code like configuration publishing ...

I propose to create a new branch dedicated to L5 version.

from laravel-push-notification.

I'd like use this lib in laravel 5 too.

from laravel-push-notification.

+1 upvote!

from laravel-push-notification.

+1

from laravel-push-notification.

👍

from laravel-push-notification.

👌

from laravel-push-notification.

+1

from laravel-push-notification.

+1

from laravel-push-notification.

+1

from laravel-push-notification.

+1

from laravel-push-notification.

Hello guys!
Sorry for being late. Laravel 5 version is now available at laravel5 branch, you can require it on composer:
"davibennun/laravel-push-notification": "dev-laravel5"
The way you use this package is the same, the only thing changed was the config file location, once you published it using php artisan vendor:publish the config file goes to app/config/push-notification.php

from laravel-push-notification.

I don't have any certificate here to fully test the package, I think its ok since changes were very small, but you never know... can someone use it in real life just to make sure everything is working?

from laravel-push-notification.

i'll be able to test it in a few days, thx for creating v5 branch :-)

from laravel-push-notification.

@davibennun Thank U. I will check this next week

from laravel-push-notification.

I am trying for Laravel 5.
config:publish is not valid command

So for "Copy the config file into your project by running"
php artisan config:publish davibennun/laravel-push-notification doesn't worked in Laravel 5

Instead this will work laravel 5 :
php artisan vendor:publish --provider="Davibennun\LaravelPushNotification\LaravelPushNotificationServiceProvider" --tag="config"

This command will created config file in L5.

from laravel-push-notification.

@agarwalVinayak I just merged the pull request that updates the documentation.

from laravel-push-notification.

@davibennun cool!! , but still doc for L5 have composer.json path
as "davibennun/laravel-push-notification": "dev-master"
and not
"davibennun/laravel-push-notification": "dev-laravel5"

from laravel-push-notification.