Comments (2)
Done, but klugily. Large monolithic validator is making tests mock out stuff I don't own. Plan: parse the URL, store as pieces, break out validations, refactor tests, and display as pieces too, with separate "open" link.
from pull-request-roulette.
Refactored, but merging in the oauth stuff broke a lot of tests. Need to figure out how to test with that....
from pull-request-roulette.
Related Issues (20)
- Let reviewers specify minimum star rating for coders HOT 2
- Make it work with private repos
- Show who took a PR
- Show who submitted a PR to PRR HOT 1
- Show who wrote a PR HOT 1
- Email submitter when someone takes a PR HOT 1
- Add Bitbucket support
- Let reviewer, coder, or project owner state that the review is finished
- Email submitter when reviewer finishes review
- Add a sign in button / link HOT 1
- Let user edit profile
- Users have profiles
- sometimes blows up
- Search bar and language filter HOT 2
- PRs still listed 3 years after closing and after repo archiving HOT 4
- Getting SPAM and non-sense pull requests? HOT 3
- Broken link on webpage HOT 2
- Https error with the site HOT 1
- The site attached to this repo is still listed on Hacktoberfest website
- Layout not responsive on all screens
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pull-request-roulette.