Support "dynamic" options about bohr HOT 9 CLOSED

Yeah this has been an idea I've had from the beginning. I'd like to discuss with you what the best approach would be.

Let's start off by discussing a simple problem: should "optional" cells depend only on boolean setting values (BOSwitchTableViewCell)? That'd simplify a lot of work, but I'm not sure about the limitations that such decision could impose.

from bohr.

Generally speaking, I've seen only bool-dependent examples in real life. However, I can imagine a case where UI should be updated when you select one of enum options in child settings view controller: returning to my example with endpoints, if you select development endpoint from list of options, the settings should show more switches/settings.

from bohr.

my original idea was to add optional block as a parameter to cell constructor, like

cell = [BOTableViewCell key:"foo" ....  visibleIf: ^ (Settings *settings) {
     \\query settings object if they meet particular condition
    return settings["endpoint"] == "development";
}]

and also some kind of property to each cell, like forcesReload (NO by default), so changing cell with this property set to YES is going to reload whole table and reevaluate visibleIf condition

from bohr.

@garnett that sounds super clever. I'm definitely into that method 👍

We could make it even more magical if we found a way to automatically determine if reloading is necessary or not depending on which setting each cell depends on. I'll think about a way to achieve that.

from bohr.

I can think of a visibilityKey property along with a visibilityBlock property passed to the right cell when its visibilityKey changes. That way, if there's a value change for that visibilityKey, we would immediately know we need to reload the table.

Also, as in most cases a cell won't need dynamic visibility, I wouldn't put anything related to it in the init method, but rather let the developer change it in the handler block.

from bohr.

Sounds good!

from bohr.

Hey there! I finally got some time to implement this feature and I think it's turned out pretty well. Check it out!

from bohr.

@davdroman looks exactly how I imagined it, 👍

from bohr.

Terrific! I'll adjust a couple little things and it'll be ready for release!

from bohr.