Escape SSH password to handle special characters about diagnostic-collection HOT 5 CLOSED

Hilton and I ran into this issue today and we fixed it by placing escaped quotes around the password passed to sshpass.

The fix would be a simple one-line change

ssh_command="sshpass -p \"$sshPassword\" $ssh_command"

Note, we tested this fix on a production cluster.

from diagnostic-collection.

related: see escape_special_chars() bash function which got dummied out. We used to escape, but we stopped because it was causing problems.

from diagnostic-collection.

There's a better solution to this though: put the password in the environment SSHPASS and use -e, rather than passing on the command line with -p.

from diagnostic-collection.

#140 should address this.

from diagnostic-collection.

Works for me!

from diagnostic-collection.